Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite: Fix a double-encode issue when using the {uri} placeholder #4516

Merged
merged 2 commits into from Jan 13, 2022
Merged

rewrite: Fix a double-encode issue when using the {uri} placeholder #4516

merged 2 commits into from Jan 13, 2022

Conversation

francislavoie
Copy link
Member

Fix #4515

@francislavoie francislavoie added bug 🐞 Something isn't working under review 🧐 Review is pending before merging labels Jan 10, 2022
@francislavoie francislavoie added this to the v2.5.0 milestone Jan 10, 2022
@francislavoie francislavoie mentioned this pull request Jan 10, 2022
Closed
5HT2
5HT2 approved these changes Jan 10, 2022
View reviewed changes
Copy link

@5HT2 5HT2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic to see my esoteric URL format has become a test :p

mholt
mholt approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Definitely inelegant, but I'm not sure a better fix for now. Thanks!

@francislavoie francislavoie merged commit 1feb659 into master Jan 13, 2022
@francislavoie francislavoie deleted the fix-rewrite-double-encode branch January 13, 2022 17:17
@mholt mholt removed the under review 🧐 Review is pending before merging label Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

@5HT2 5HT2 5HT2 approved these changes

@mohammed90 mohammed90 Awaiting requested review from mohammed90

Assignees
No one assigned
Labels
bug 🐞 Something isn't working
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.

rewrite double-encodes url
3 participants
@francislavoie @mholt @5HT2