Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max_buffer_size doesn't support go-humanize format #5095

Closed
bt90 opened this issue Sep 29, 2022 · 1 comment
Closed

max_buffer_size doesn't support go-humanize format #5095

bt90 opened this issue Sep 29, 2022 · 1 comment
Labels
bug 🐞 Something isn't working
Milestone

Comments

@bt90
Copy link
Contributor

bt90 commented Sep 29, 2022

I'm toying a bit with OpenSpeedTest and tried to tune the max_buffer_size option of the reverse_proxy directive. According to the docs go-humanize formats should be supported:

speed.example.com {

        reverse_proxy http://localhost:8086 {
                buffer_requests
                max_buffer_size 50MiB
        }
}
Error: adapting config using caddyfile: parsing caddyfile tokens for 'reverse_proxy': /etc/caddy/Caddyfile:112 - Error during parsing: invalid size (bytes): 50MiB
@mholt mholt closed this as completed in 2a8c458 Sep 29, 2022
@mholt
Copy link
Member

mholt commented Sep 29, 2022

Oops, thanks for the report. Fixed in 2a8c458. Please feel free to try it out!

@mholt mholt added the bug 🐞 Something isn't working label Sep 29, 2022
@mholt mholt added this to the v2.6.2 milestone Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants