Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please keep the original ip_hash algorithm #5340

Closed
since1986 opened this issue Jan 28, 2023 · 2 comments
Closed

Please keep the original ip_hash algorithm #5340

since1986 opened this issue Jan 28, 2023 · 2 comments
Labels
declined 🚫 Not a fit for this project

Comments

@since1986
Copy link

since1986 commented Jan 28, 2023 •
edited

By reading the git history, I found that caddy has changed the hashing algorithm func hostByHashing(pool []*Upstream, s string) *Upstream) which brings some troubles to the joint use of caddy and caddy-l4, please refer to this issue for details. Is it possible to keep the old and new hash algorithms at the same time, instead of replacing the old with the new?
@since1986 since1986 mentioned this issue Jan 28, 2023
Closed
@francislavoie
Copy link
Member

Why do you think the original is still needed? I don't understand. Shouldn't we just update caddy-l4 to match the new one?

@mholt
Copy link
Member

mholt commented Jan 28, 2023

The old algorithm was flawed (see this also); the new one is much better. I don't see any compelling reason to keep the old one.

@mholt mholt closed this as not planned Won't fix, can't repro, duplicate, stale Jan 28, 2023
@mholt mholt added the declined 🚫 Not a fit for this project label Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
declined 🚫 Not a fit for this project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mholt @francislavoie @since1986