Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Eliminate unnecessary shutdown delay on Unix #5413

Merged
merged 3 commits into from Mar 3, 2023
Merged

core: Eliminate unnecessary shutdown delay on Unix #5413

merged 3 commits into from Mar 3, 2023

Conversation

mholt
Copy link
Member

@mholt mholt commented Mar 3, 2023

Fix #5393, alternate to #5405.

I haven't had a chance to thoroughly test this yet because my curl installation is currently borked.

I still need to clean it up a bit and add explanatory comments if this works, so don't merge it yet.

/cc @francislavoie

@mholt mholt requested a review from francislavoie March 3, 2023 03:37
@francislavoie francislavoie added the bug 🐞 Something isn't working label Mar 3, 2023
@francislavoie francislavoie added this to the v2.7.0 milestone Mar 3, 2023
francislavoie
francislavoie approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@francislavoie francislavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it with --watch and editing a Caddyfile, it works! 👍

@francislavoie francislavoie mentioned this pull request Mar 3, 2023
Closed
@mholt
Copy link
Member Author

mholt commented Mar 3, 2023

Oops. I guess _unix isn't a thing in Go filenames, as those only work with literal GOOS values, and unix is a shortcut that is allowed only for actual build tags. Oh well. Who needs Windows anyway 😜

@mholt mholt enabled auto-merge (squash) March 3, 2023 03:57
@mholt
Copy link
Member Author

mholt commented Mar 3, 2023

Thank you for verifying it works, Francis! Really appreciate all you do.

@mholt mholt merged commit 99d4705 into master Mar 3, 2023
@mholt mholt deleted the fix-shutdown-delay-2 branch March 3, 2023 04:00
mholt added a commit that referenced this pull request Jan 23, 2024
@mholt
core: Eliminate unnecessary shutdown delay on Unix (#5413)
affc850 
* core: Eliminate unnecessary shutdown delay on Unix

Fix #5393, alternate to #5405

* Comments, cleanup, adjust logs

* Fix build constraint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francislavoie francislavoie francislavoie approved these changes

Assignees
No one assigned
Labels
bug 🐞 Something isn't working
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.

Slow config reload when using shutdown_delay
2 participants
@mholt @francislavoie