Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acmeserver: support specifying the allowed challenge types #5794

Merged
merged 18 commits into from
Feb 8, 2024

Conversation

mohammed90
Copy link
Member

@mohammed90 mohammed90 commented Sep 1, 2023

TODO:

  • Tests
  • Docs
  • website docs (once approved)

There will be another PR for the ability to control the allowed names, denied names, and wild cards.

@mohammed90 mohammed90 added the feature ⚙️ New feature or request label Sep 1, 2023
@mohammed90 mohammed90 added this to the 2.9.0 milestone Sep 1, 2023
@mohammed90 mohammed90 added needs docs ✍️ Requires documentation changes needs tests 💯 Requires automated tests labels Sep 3, 2023
@mholt
Copy link
Member

mholt commented Sep 7, 2023

Some awesome upgrades coming to the ACME server / PKI stuff. I like it!

Let me know when you're ready for final review(s).

@mohammed90 mohammed90 force-pushed the acme-enhancement branch 4 times, most recently from 9144930 to 492dcaf Compare December 29, 2023 15:01
@mohammed90 mohammed90 marked this pull request as ready for review January 5, 2024 20:45
@mohammed90 mohammed90 requested a review from mholt January 5, 2024 20:47
@mohammed90 mohammed90 removed needs docs ✍️ Requires documentation changes needs tests 💯 Requires automated tests labels Jan 5, 2024
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for working on it. Looks good to me :)

mohammed90 and others added 2 commits February 5, 2024 17:29
Co-authored-by: Matt Holt <mholt@users.noreply.github.com>
@mohammed90 mohammed90 merged commit e1aa862 into master Feb 8, 2024
25 checks passed
@mohammed90 mohammed90 deleted the acme-enhancement branch February 8, 2024 08:42
@francislavoie francislavoie modified the milestones: v2.9.0, v2.8.0 Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ⚙️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants