httpcaddyfile: Allow nameless regexp placeholder shorthand #6113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just read the code for regexp matchers, and saw this:
This made me realize that we're always setting regexp placeholders, even if a name isn't specified... but our Caddyfile placeholder shorthand wasn't allowing
{re.1}
, it was only shortening long-form placeholders! Silly oversight...Now, this is possible:
Specifying a name is only necessary if there's more than one matcher in the set (e.g. header_regexp + path_regexp at the same time), or if you want to carry the matcher result for later use if there's a risk that another regexp matcher might be used. But for the majority of cases, the simple case with no name is perfectly fine.