Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New quic-go@v0.42.0 causes build failure of app that is using caddy #6209

Closed
jediknight112 opened this issue Apr 2, 2024 · 5 comments
Closed
Labels
dependencies ⛓️ Pull requests that update a dependency file

Comments

@jediknight112
Copy link

In the latest release of quic-go https://github.com/quic-go/quic-go/releases/tag/v0.42.0 the quic.Config struct was modified and no longer has the RequireAddressValidation field in the quic.Config struct which results in this build error:

vendor/github.com/caddyserver/caddy/v2/listeners.go:477:4: unknown field RequireAddressValidation in struct literal of type quic.Config
vendor/github.com/caddyserver/caddy/v2/listeners.go:516:4: unknown field RequireAddressValidation in struct literal of type quic.Config

I bring this up because I received a Dependabot alert that guic-go@v0.42.0 is the secure version based on this GitHub Advisory Database link: GHSA-c33x-xqrf-c478

@mohammed90
Copy link
Member

mohammed90 commented Apr 2, 2024

It's already upgraded in #6176. If you want it, you can build from HEAD.

@mohammed90 mohammed90 added the dependencies ⛓️ Pull requests that update a dependency file label Apr 2, 2024
@jediknight112
Copy link
Author

While we can reference the commit SHA of main I pull this module into my go app via my go.mod and the latest release tag. Is there any ETA on when a new release is going to be made so i can just reference the new release instead of the main commit SHA?

@francislavoie
Copy link
Member

We were hoping to get the release out in March, but we're all short on time so we didn't make that goal. Soon™

@mholt
Copy link
Member

mholt commented Apr 4, 2024

Yeah, my bad -- my notification backlog is down to just about 1 page now.

@epelc
Copy link
Contributor

epelc commented Apr 6, 2024

For anyone trying to do this you can run the following:

go get github.com/caddyserver/caddy/v2@master
# update list of other deps
go mod tidy
# Pull in above repo update from caddy if you use vendoring
go mod vendor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ⛓️ Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

5 participants