Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP/2 continuation flood (FYI) #6219

Closed
systemcrash opened this issue Apr 4, 2024 · 5 comments
Closed

HTTP/2 continuation flood (FYI) #6219

systemcrash opened this issue Apr 4, 2024 · 5 comments

Comments

@systemcrash
Copy link

https://nowotarski.info/http2-continuation-flood-technical-details/

@francislavoie
Copy link
Member

My understanding is this is already fixed in Go, you just need to build Caddy with the latest Go version. Nothing for us to do here.

@francislavoie francislavoie closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2024
@makew0rld
Copy link

Is making a new release with prebuilt binaries that don't contain this bug an option? Currently I've installed Caddy through Caddy's Debian repos and I was hoping for there to be a solution that would just be apt upgrade caddy instead of building from source.

@bartekn
Copy link

bartekn commented Apr 4, 2024

My understanding is this is already fixed in Go, you just need to build Caddy with the latest Go version. Nothing for us to do here.

The issue is also in golang.org/x/net (actually it's only there, Golang just bundles it's http2 package to standard net/http as h2_bundle.go file) and Caddy imports it here:

"golang.org/x/net/http2"

The version imported is 0.22:

caddy/go.mod

Line 41 in 45132c5

golang.org/x/net v0.22.0

and the security advisory includes this version as vulnerable.

@francislavoie
Copy link
Member

You should be able to build from master now to have the fix.

@makew0rld
Copy link

Will there be a new release for this? Thanks for the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants