fileserver: Read Etags from precomputed files #6222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armadi1809
force-pushed
the
aar-read-etag-from-files
branch
from
01a0959
to
77a845f
Compare
armadi1809
changed the title
jdog10141
approved these changes
Apr 5, 2024
mholt
requested changes
Apr 11, 2024
francislavoie
changed the title
armadi1809
force-pushed
the
aar-read-etag-from-files
branch
from
77a845f
to
2bd54ef
Compare
|
Thanks for taking a look at this Matt. All the feedback discussions should now be resolved. |
mholt
reviewed
Apr 13, 2024
Comment on lines
666
to
669
| _, err := fs.Stat(fileSystem, etagFilename) | ||
| if err != nil { | ||
| continue | ||
| } |
There was a problem hiding this comment.
Is the purpose of this to check whether we can access the file? Maybe we can eliminate this system call and instead just call fs.ReadFile() directly. Then:
if errors.Is(err, fs.ErrNotExist) {
continue
}
if err != nil {
return "", fmt.Errorf("cannot read etag from file %s: %v", etagFilename, err)
}What do you think?
(I just noticed this. sorry. lol)
There was a problem hiding this comment.
Much much better. Just changed it. Thanks!
armadi1809
force-pushed
the
aar-read-etag-from-files
branch
from
2bd54ef
to
6fc1713
Compare
mholt
approved these changes
Apr 13, 2024
|
Awesome, thanks for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial pass at closing #5734