Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing: add http.vars.trace_id placeholder #6308

Merged
merged 1 commit into from
May 8, 2024

Conversation

matthewpi
Copy link
Member

Adds the ability to use trace_id as a placeholder so it can be used wherever it is needed. Such as being returned in a header to the client.

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about the tracing code but I think this looks reasonable. Thanks!

@francislavoie francislavoie changed the title modules(tracing): add http.vars.trace_id placeholder tracing: add http.vars.trace_id placeholder May 8, 2024
@francislavoie francislavoie added the feature ⚙️ New feature or request label May 8, 2024
@francislavoie francislavoie added this to the v2.8.0 milestone May 8, 2024
@mholt mholt merged commit 0b5720f into caddyserver:master May 8, 2024
23 checks passed
@matthewpi matthewpi deleted the trace-id-placeholder branch May 8, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ⚙️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants