Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add camera iframe option with height option #425

Merged
merged 6 commits into from Nov 18, 2021

Conversation

dragonnn
Copy link
Contributor

@dragonnn dragonnn commented Oct 7, 2021

Hi :)
I just started setting up my klipper setup with fluidd and found out that you can not setup camera as a simple iframe.
I am using https://github.com/dans98/pi-h264-to-browser with works much better then any mjpeg options.
Uses less bandwidth and runs with hw accel in your browser but needs to be setup as a simple web page.
So I add an iframe option named "HTTP Page".
I also add to it an height option, it is a not perfect workaround around the iframe not scaling automatic.
Another option to fix that would be onLoad on the iframe but that would work only if the webserwer and camera are on the same origin with isn't always the case.
My first time writing code for vue, so any suggestion are welcome if something isn't up to the standards.
In general works really well:
image

@Doridian
Copy link

Is there anything missing to get this in?

I set up webrtc-streamer to get a very low latency (and low bandwidth) camera feed from my printer into a browser, sadly fluidd's options do not allow me to embed that at all.

@dragonnn
Copy link
Contributor Author

For my application I don't miss anything.
Maybe the only complain about is the need to set the height of the camera stream because it is kind a workaround, but I personal don't see an issue with it.
Also if you don't hit a cross-orgin issue the iframe code can adjust it's height automatic from inside if it has the right code for it as far I know.

@dweight dweight merged commit ec6ab04 into fluidd-core:develop Nov 18, 2021
@dragonnn dragonnn mentioned this pull request Jan 3, 2022
@matmen matmen added this to the Release: 1.17 milestone Feb 22, 2022
@matmen matmen added Docs - Needed Docs need to be added for tagged issue UI - Cams Everything related to cameras in fluidd. labels Feb 22, 2022
@matmen matmen mentioned this pull request Feb 23, 2022
7 tasks
matmen pushed a commit to matmen/fluidd that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs - Needed Docs need to be added for tagged issue UI - Cams Everything related to cameras in fluidd.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants