Add camera iframe option with height option #425
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi :)
I just started setting up my klipper setup with fluidd and found out that you can not setup camera as a simple iframe.
I am using https://github.com/dans98/pi-h264-to-browser with works much better then any mjpeg options.
Uses less bandwidth and runs with hw accel in your browser but needs to be setup as a simple web page.
So I add an iframe option named "HTTP Page".
I also add to it an height option, it is a not perfect workaround around the iframe not scaling automatic.
Another option to fix that would be onLoad on the iframe but that would work only if the webserwer and camera are on the same origin with isn't always the case.
My first time writing code for vue, so any suggestion are welcome if something isn't up to the standards.
In general works really well: