Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split systems into multiple dispatchers and use FlaggedStorage #62

Merged
merged 8 commits into from Aug 17, 2019

Conversation

caelunshun
Copy link
Member

Resolves #59.
Resolves #45.

@caelunshun caelunshun added this to the 0.4 milestone Aug 16, 2019
@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #62 into develop will decrease coverage by 0.96%.
The diff coverage is 93.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #62      +/-   ##
==========================================
- Coverage    52.46%   51.5%   -0.97%     
==========================================
  Files           47      50       +3     
  Lines         6221    6124      -97     
==========================================
- Hits          3264    3154     -110     
- Misses        2957    2970      +13
Impacted Files Coverage Δ
server/src/physics/component.rs 90.24% <ø> (-2.78%) ⬇️
server/src/player/mod.rs 100% <100%> (ø)
server/src/physics/mod.rs 100% <100%> (ø)
server/src/chunk_logic.rs 64.94% <100%> (+0.48%) ⬆️
server/src/entity/mod.rs 100% <100%> (ø)
server/src/util.rs 100% <100%> (ø) ⬆️
server/src/testframework.rs 91.24% <100%> (-7.34%) ⬇️
server/src/player/init.rs 100% <100%> (+4.16%) ⬆️
server/src/player/broadcast.rs 84.5% <100%> (+4.24%) ⬆️
server/src/physics/math.rs 93.44% <100%> (-0.55%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2afe021...e3a1299. Read the comment docs.

@caelunshun caelunshun marked this pull request as ready for review August 17, 2019 00:16
@caelunshun caelunshun merged commit 06210a5 into develop Aug 17, 2019
@caelunshun caelunshun deleted the multiple-dispatchers branch August 17, 2019 00:53
@caelunshun caelunshun mentioned this pull request Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split systems into multiple dispatchers Use specs::FlaggedStorage over custom shrev events everywhere
1 participant