Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different from Core Foundry #1

Closed
9ryex5 opened this issue Jan 3, 2022 · 1 comment
Closed

Different from Core Foundry #1

9ryex5 opened this issue Jan 3, 2022 · 1 comment

Comments

@9ryex5
Copy link

9ryex5 commented Jan 3, 2022

Without any walls on the scene, this module draws cones and circles differently from Core Foundry.

image

@9ryex5 9ryex5 changed the title Different than Core Foundry Different from Core Foundry Jan 3, 2022
@caewok
Copy link
Owner

caewok commented May 10, 2022

Fixed by v 0.2.0.

There could still be variations from Core Foundry because when Core determines which grid squares are highlighted, it is comparing against the concept of a circle (radius + center point) while the walled template must rely on an approximation of the circle using a polygon. This approximation can be slightly off, which can make a big difference in what edge grid squares are included. That said, I think I have matched what should happen in the no-wall versions for the current Core templates.

For example, this image is actually of the Foundry circle (blue) with the walled-template version (red) laid over top. They look identical, but are not in fact identical:
Screen Shot 2022-05-09 at 3 04 09 PM

If you find other cases where the templates appear off from what you would expect in Core, please let me know and I can see if I can tweak the algorithm further.

@caewok caewok closed this as completed May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants