Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug/Feature Request?] not correctly truncating templates in PF2e #4

Closed
esheyw opened this issue May 10, 2022 · 6 comments
Closed

[Bug/Feature Request?] not correctly truncating templates in PF2e #4

esheyw opened this issue May 10, 2022 · 6 comments

Comments

@esheyw
Copy link

esheyw commented May 10, 2022

https://i.imgur.com/SmtvKHp.png this is a circle template, in pf2e using the default 'burst' rules. You can see the template edge(?) is being properly constrained, but the grid space selection is still acting like before.

@caewok
Copy link
Owner

caewok commented May 11, 2022

Is this still happening in version 0.2.3? Below is a similar setup in 5e where the circle template is inside the building and shoots out the door. Just in case, also please make sure that "Blocked by walls" is checked in the template config.

Screen Shot 2022-05-11 at 4 12 09 PM

I will leave open for now, and if it is still an issue, I can see if there is something different about pf2e that could be causing it.

@esheyw
Copy link
Author

esheyw commented May 13, 2022

Can confirm I'm on 0.2.3, PF2E 3.9.2(latest): https://gfycat.com/serpentinedistortedballpython

@esheyw
Copy link
Author

esheyw commented May 13, 2022

Rectangle and Ray work correctly, Cone and Circle do not

@caewok
Copy link
Owner

caewok commented May 14, 2022

Thanks for that. I see the issue—Pathfinder ignores the created shape for cone and circle and does its own thing for highlighting the underlying grid. In other words, Pathfinder assumes that it is getting a cone but never checks that. Not Immediately obvious how to fix it—I think I need to dig into the Pathfinder rules and override what the pathfinder system is doing. I can easily skip what Pathfinder is doing, but I would want to try to replicate the rule so it is consistent with the Pathfinder default.

Similar issue to #5 in that DF Template Enhancement also ignores the shape passed to it and does its own thing for grid highlighting.

@esheyw
Copy link
Author

esheyw commented May 15, 2022

Yea, I guess the pf2e area rules don't line up with foundry basics exactly. If you can manage a workaround that'd be excellent; I'll probably keep this active anyway since it works partially, giving the new template outline, even if that can be hard to see.

Also being compatible with DF Templates would be glorious, but since that module also isn't playing well with PF2e templates right now, not at the top of my wishlist.

@caewok
Copy link
Owner

caewok commented May 19, 2022

Should be fixed in v0.2.5. As for DF Templates, I added an issue ticket to DF Templates. Not sure I can fix compatibility just at my end; I think DF Templates would need some modifications.

@caewok caewok closed this as completed May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants