Frosting: How to stop parallel/background execution of Tasks?

[bergziege]

Hi and a happy new year to everyone ;-)

I currently having a weird behaviour executing context.AzurePipelines().Commands.UploadArtifact which seems to be running async.
How do I know? At least thats how the log tells me:

========================================
Upload Artifacts
========================================
Remote Build - Artefakte werden über die Pipeline bereitgestellt.
Upload läuft ...                            <----- Calling context.AzurePipelines().Commands.UploadArtifact here

========================================
UploadArtifactsToTransfer
========================================
An error occurred when executing task 'UploadArtifactsToTransfer'.

----------------------------------------
Teardown
----------------------------------------
Tearing things down...
Error: Error deleting file 'D:\a\1\s\ToBePublished\Some_App-2.4.0.zip'.
System Error.  Code: 32.
The process cannot access the file because it is being used by another process
[...]
Uploading 1 files                         <----- Log output for upload starts here
Total file: 1 ---- Processed file: 0 (0%)
Uploading 'website/Some_App-2.4.0.zip' (5%)
Uploading 'website/Some_App-2.4.0.zip' (10%)
Uploading 'website/Some_App-2.4.0.zip' (15%)
Uploading 'website/Some_App-2.4.0.zip' (20%)
Uploading 'website/Some_App-2.4.0.zip' (25%)

My task dependencies are strict sequencial on terms of Build -> Test -> Pack -> UploadToPipeline -> UploadArtifactsToTransfer.

So how do I wait? for the upload task to finish as context.AzurePipelines().Commands.UploadArtifact looks like a blocking call to me?

[devlead]

UploadArtifact command only sends a console log command to the Azure DevOps build agent which parses the log and starts a background process that will store and associate the artifact with the build. So it's per definition an asynchronous process.

cake/src/Cake.Common/Build/AzurePipelines/AzurePipelinesCommands.cs

Lines 173 to 179 in a5cbbfa

	public void UploadArtifact(string folderName, FilePath file)
	{
	WriteLoggingCommand("artifact.upload", new Dictionary<string, string>
	{
	["containerfolder"] = folderName
	}, file.MakeAbsolute(_environment).FullPath);
	}

cake/src/Cake.Common/Build/AzurePipelines/AzurePipelinesCommands.cs

Lines 182 to 189 in a5cbbfa

	public void UploadArtifact(string folderName, FilePath file, string artifactName)
	{
	WriteLoggingCommand("artifact.upload", new Dictionary<string, string>
	{
	["containerfolder"] = folderName,
	["artifactname"] = artifactName
	}, file.MakeAbsolute(_environment).FullPath);
	}

[pascalberger]

As @devlead said service messages will always be async. There's a Cake.AzureDevOps addin which uses the REST API. The AzureDevOpsBuild can give you access to the current running build and returns a AzureDevOpsBuild object which then can be used to call to Azure DevOps. I currently only has a LinkArtifact method, to link to an artifact, but support for publishing artifacts to Azure DevOps could be added in a similar fashion to the addin. I would be happy to accept a PR for this 😄

Other possibility would be to call the GetArtifacts method and wait until the artifact is uploaded, but this would be more of a workaround than a clean solution.