Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signtool.exe should be called only once when signing multiple files #1513

Closed
thomaslevesque opened this issue Feb 28, 2017 · 1 comment
Closed

signtool.exe should be called only once when signing multiple files #1513

thomaslevesque opened this issue Feb 28, 2017 · 1 comment
Labels
Improvement
Milestone
v0.18.0

Comments

@thomaslevesque
Copy link
Contributor

Currently the Sign method calls signtool.exe for each file to sign. It's not actually necessary, signtool can sign multiple files at once, which is noticeably faster.
@thomaslevesque
Copy link
Contributor Author

I'll send a PR soon.

@thomaslevesque thomaslevesque mentioned this issue Mar 1, 2017
Merged
@devlead devlead added this to the v0.18.0 milestone Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
v0.18.0
Development

No branches or pull requests
2 participants
@devlead @thomaslevesque