Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLabCI variable changes. #1731

Closed
phillipsj opened this issue Aug 6, 2017 · 6 comments
Closed

GitLabCI variable changes. #1731

phillipsj opened this issue Aug 6, 2017 · 6 comments
Milestone

Comments

@phillipsj
Copy link
Contributor

I stumbled across this documentation today where the environment variables have had their names changed for the 9.0 release. I don't know if this will effect anything currently, but worth putting on the radar.

@patriksvensson
Copy link
Member

Hmm, it should be safe to look for both values I think unless I've missed something?

Great find @phillipsj!

@Roemer
Copy link
Contributor

Roemer commented Aug 18, 2017

The Gitlab "wrapper" suffers the same issue the Jenkins one does: It has several "xxxInfo" classes. Now with the renaming, new classes should be introduced and properties should be moved between them. Would it be acceptable to reduce the classes to one or two and in the same time, add the new 9.0 names as alternative?

@phillipsj
Copy link
Contributor Author

@devlead @gep13 @patriksvensson I will take this one if cool with you all.

@devlead
Copy link
Member

devlead commented Oct 7, 2017

Knock yourself out 👍

@phillipsj
Copy link
Contributor Author

Linked to PR #1866

@patriksvensson
Copy link
Member

Resolved via PR #1866.

@gep13 gep13 added this to the v0.23.0 milestone Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants