Make easier to search files in a certain directory

[Kralizek]

I often find myself in the situation of looking for files matching a certain pattern within a folder or below.

Here is a typical use case

As of today, executing dotnet test on a solution will try to find and execute tests on every project filling the log with errors because no testable project was found. This is why I prefer to find every project file within the tests directory hive.

Task("Test")
    .IsDependentOn("Build")
    .Does(() => 
{
    var testProjects = FindFilesInDirectory(testDirectory, "*.csproj", SearchScope.Recursive);

    foreach (var project in testProjects)
    {
        DotNetCoreTest(project.FullPath);
    }
});

I am aware that the same functionality is offered by IFileSystem but the result of IFileSystem.GetFiles is a list of IFile instead of FilePath. This is not convenient since most of the aliases work with FilePath.

[Kralizek]

@patriksvensson

[patriksvensson]

@Kralizek Great!

The name indicates that it returns files and not file paths. Perhaps it should be renamed to something like GetFilePaths instead?

I'm also curious to why this method takes a DirectoryPath, pattern and SearchScope instead of a glob pattern, such as $"{testDirectory}/**/*.csproj". This would be more constistent with the GetFiles alias that already exist.

@devlead: What is your opinion?

[Kralizek]

I didn't like that I had to write GetFiles(testDirectory.FullPath + "/**/*.csproj"), but I didn't know that GetFiles($"{testDirectory}/**/*.csproj") is supported.

[DavidPerikala]

Hello. This looks interesting and I would like to work on it.
Can you elaborate a bit on what is needed. ?
I tried to get familiar with IFileSystem.GetFiles, But I couldn't locate it in the interface. Is it deprecated now?

[DurveshKumarPal]

Hey @augustoproiete , I would like to work on it Could you please Assigned to me.

[augustoproiete]

@DurveshKumarPal all yours

[augustoproiete]

Hey @DurveshKumarPal didn't hear back from you in a few months. Any chance you'll work on this soon?