Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensibility issue - CakeTaskBuilder is sealed and CakeTaskBuilder(CakeTask task) is internal. #2591

Closed
vijaygill opened this issue Aug 5, 2019 · 5 comments · Fixed by #3955
Milestone

Comments

@vijaygill
Copy link

vijaygill commented Aug 5, 2019

While attempting a little idea in my mind, I tried implementing my own cake engine (by implementing ICakeEngibe) but faced following issue:

CakeTaskBuilder(CakeTask task) is marked as internal and the class itself is sealed. So I cannot implement my own CakeTaskBuilder ICakeEngine.RegisterTask(string name) in the new cake-engine class (on the same lines as the original one. Also CakeEngine itself is marked as sealed. So I cannot subclass it and override some functionality.

As suggested on the chat, I am opening this issue so that the cake can be refactored to make it more extensible (after discussing it here).

Thanks.

@bjorkstromm
Copy link
Member

@vijaygill thanks!

/cc @patriksvensson this is what we discussed.

@patriksvensson
Copy link
Member

@mholo65 I will take a look and see what needs to be done

@vijaygill
Copy link
Author

@patriksvensson Did you get a chance to look at this please?

@twenzel
Copy link
Contributor

twenzel commented Sep 1, 2022

@pascalberger I've created a small PR to fix this long standing issue.

@cake-build-bot
Copy link

🎉 This issue has been resolved in version v2.3.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants