Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet test test-adapter-path should be collection of DirectoryPath instead of single DirectoryPath #3839

Open
2 tasks done
AdaskoTheBeAsT opened this issue Mar 13, 2022 · 3 comments

Comments

@AdaskoTheBeAsT
Copy link
Contributor

Prerequisites

  • I have written a descriptive issue title
  • I have searched issues to ensure it has not already been reported

Cake runner

Cake .NET Tool, Cake Frosting

Cake version

2.1

Operating system

Linux, Windows, macOS

Operating system architecture

64-Bit

CI Server

No response

What are you seeing?

https://cakebuild.net/api/Cake.Common.Tools.DotNet.Test/DotNetTestSettings/AA9D5613

public DirectoryPath TestAdapterPath { get; set; }

What is expected?

public DirectoryPath[] TestAdapterPath { get; set; }

Steps to Reproduce

it seems that dotnet test can use multiple test adapters

Output log

No response

@gep13
Copy link
Member

gep13 commented Jun 12, 2022

@AdaskoTheBeAsT can you provide a link to the docs for dotnet test for what you are describing.

Based on what I am reading here:

https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-test#options

It would suggest that this should only be a single directory path:

Path to a directory to be searched for additional test adapters. Only .dll files with suffix .TestAdapter.dll are inspected. If not specified, the directory of the test .dll is searched.

@FreshKhalifa

This comment was marked as spam.

@AdaskoTheBeAsT
Copy link
Contributor Author

@gep13 I have reproductible case which is connected with Cake.ReSharper.GlobalTools
when commenting line 40 or 41 problem appears - it seems it is somewhat hidden gem

https://github.com/AdaskoTheBeAsT/Cake.ReSharper.GlobalTools/blob/feature/initial-implementation/build/Tasks/UnitTestTask.cs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants