Allow use of ICakeContext in WithCriteria

[jrnail23]

Overload CakeTaskBuilder.WithCriteria to accept Func<ICakeContext,bool>.
I'm factoring out some common behaviors in my scripts into reusable tasks, but not having the context available in WithCriteria is causing some friction.

Anyone have a reason that context shouldn't be allowed there?

[patriksvensson]

Sounds like a reasonable addition. Will make the task API more consistent as well 👍

[ErikSchierboom]

I am looking into this, and was wondering how I should add it to the existing CakeTask class. This class has a property that contains all existing boolean criterias: public IReadOnlyList<Func<bool>> Criterias. In the ShouldTaskExecute method in the CakeEngine class, the aforementioned Criterias property is iterated over. Should I create an additional property which signature is like this: public IReadOnlyList<Func<ICakeContext, bool>> ContextCriterias? Or should Func<bool> instances be converted to Func<ICakeContext, bool> instances and the existing Criterias property thus return IReadOnlyList<Func<ICakeContext, bool>>?

[patriksvensson]

@ErikSchierboom I don't have the source code in front of me but will get back to you later tonight. 👍

[patriksvensson]

@ErikSchierboom I would prefer if we changed CakeTask.Criterias to be a IReadOnlyList<Func<ICakeContext, bool>> and converted the Func<bool> to a Func<ICakeContext, bool>.

We could also make the void AddCriteria(Func<bool> criteria) an extension method (since it's more or less a convenience method) and change the implementation in CakeTask to void AddCriteria(Func<ICakeContext, bool> criteria)

[patriksvensson]

Merged via #663.