Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support XUnit's x86 .exe runner #670

Closed
martingem opened this issue Jan 30, 2016 · 8 comments
Closed

Support XUnit's x86 .exe runner #670

martingem opened this issue Jan 30, 2016 · 8 comments
Assignees
Milestone

Comments

@martingem
Copy link

Probably something I'm missing regarding running XUnit with x86, but:

The problem I'm having is mainly when trying to run tests based on ARM architecture for Windows Phone, where the 64 bit runner doesn't work with the ARM/x86 set. However, when using xunit.console.x86.exe, it works. It would be nice to (solution) add a parameter to XUnit2Settings to use the x86 .exe instead of the 64 bit one (aka xunit.console.exe), or detect the build somehow.

Related to this ?
Thanks!

@devlead
Copy link
Member

devlead commented Jan 30, 2016

What you could do today is to specify the tool path:

#tool "xunit.runner.console"
XUnit2("./src/**/bin/" + configuration + "/*.Tests.dll", new XUnit2Settings {
        ToolPath = "./tools/xunit.runner.console/tools/xunit.console.x86.exe"
        });

@martingem
Copy link
Author

@devlead That works!
Anything in the works to do something according to the build target?

Thanks a lot!

@wieslawsoltes
Copy link

Having same issue, would be nice to have in XUnit2Settings parameter for target platform x86 or x64.

@phillipsj
Copy link
Contributor

@devlead I will take this one. If there are any design considerations I will post back here.

@devlead
Copy link
Member

devlead commented Oct 25, 2016

@phillipsj perfect 👍

@phillipsj
Copy link
Contributor

@devlead @gep13 @patriksvensson So I have two different implementations. One is a tool resolver and the other changes how tooling works in general. One addresses xUnit and the other allows all tools to define x86 support. Is there a preference?

@patriksvensson
Copy link
Member

@phillipsj Since all tools doesn't have a corresponding x86-implementation, I think it would suffice with a fix for xunit at this time.

@devlead devlead added this to the v0.18.0 milestone Nov 11, 2016
@devlead
Copy link
Member

devlead commented Nov 11, 2016

Fixed by #1336

@devlead devlead closed this as completed Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants