Add Cake.ExtractLicenses.yml #2403
Conversation
| Description: >- | ||
| The Cake-Addin of the Liz-Tool - which helps to extract license-information from your solution/project | ||
| aimed on a fast and correct process. |
There was a problem hiding this comment.
We should cleanup description
| TargetFrameworks: | ||
| - netcoreapp3.1 | ||
| - net5.0 | ||
| - net6.0 |
There was a problem hiding this comment.
Target Cake version and TFM doesn't seem to match regarding best practices. We should check this with addin author.
There was a problem hiding this comment.
Hey I'm the author of the addin. What is the issue here?
I was using the recommended .NET target version and the Cake-Version 0.38.0 to be able to support as many users as possible. Do these two not fit together?
There was a problem hiding this comment.
Hey @wgnf we use major versions of Cake to introduce breaking changes to APIs, so when an addin targets Cake v0.38.0 we can't be sure it will work with Cake v1.0.0 or v2.0.0, or v3.0.0 (latest as of this writing), so your addin should ideally target the most recent major Cake version
You can see more details in the documentation: https://cakebuild.net/docs/extending/addins/best-practices#cake-reference
If you do want to support as many users as possible (and you don't mind the extra work), you should release separae versions of your addin compatible with each Cake major version you want to support.
There was a problem hiding this comment.
Yeah that totally makes sense (idk what I was thinking there 😅). I'll have a look at that in the next few days.
There was a problem hiding this comment.
Just released version 2.0.0 of Cake.ExtractLicenses now targeting version 3.0.0 (see https://github.com/wgnf/liz/releases/tag/v2.0.0)
thank you!
There was a problem hiding this comment.
Awesome. Thank you @wgnf!
|
@wgnf just released a new version of the addin that targets Cake v3.0.0 so closing this PR to let the AddinDiscoverer create a new one with the latest version |
augustoproiete
deleted the
add_Cake.ExtractLicenses.yml_2022_03_02_16_48_25
branch
This pull request was created by a tool: Cake.AddinDiscoverer version 4.4.0
Resolves #2402