This repository has been archived by the owner on Dec 25, 2023. It is now read-only.
/
XmlFileLoggerLogFileFormatTests.cs
463 lines (426 loc) · 23.7 KB
/
XmlFileLoggerLogFileFormatTests.cs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
namespace Cake.Issues.MsBuild.Tests.LogFileFormat
{
using System;
using System.IO;
using System.Linq;
using Cake.Core.Diagnostics;
using Cake.Issues.MsBuild.LogFileFormat;
using Cake.Issues.Testing;
using Shouldly;
using Xunit;
public sealed class XmlFileLoggerLogFileFormatTests
{
public sealed class TheCtor
{
[Fact]
public void Should_Throw_If_Log_Is_Null()
{
// Given
ICakeLog log = null;
// When
var result = Record.Exception(() => new XmlFileLoggerLogFileFormat(log));
// Then
result.IsArgumentNullException("log");
}
}
public sealed class TheReadIssuesMethod
{
[Fact]
public void Should_Read_Full_Log_Correct()
{
// Given
var fixture = new MsBuildIssuesProviderFixture<XmlFileLoggerLogFileFormat>("FullLog.xml");
// When
var issues = fixture.ReadIssues().ToList();
// Then
issues.Count.ShouldBe(19);
IssueChecker.Check(
issues[0],
IssueBuilder.NewIssue(
"The variable 'foo' is assigned but its value is never used",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProject(@"src\ClassLibrary1\ClassLibrary1.csproj", "ClassLibrary1")
.InFile(@"src\ClassLibrary1\Class1.cs", 13, 17)
.OfRule("CS0219")
.WithPriority(IssuePriority.Warning));
IssueChecker.Check(
issues[1],
IssueBuilder.NewIssue(
"Enable XML documentation output",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProject(@"src\ClassLibrary1\ClassLibrary1.csproj", "ClassLibrary1")
.InFile(@"src\ClassLibrary1\Class1.cs", 1, 1)
.OfRule("SA1652", new Uri("https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1652.md"))
.WithPriority(IssuePriority.Warning));
IssueChecker.Check(
issues[2],
IssueBuilder.NewIssue(
"The file header is missing or not located at the top of the file.",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProject(@"src\ClassLibrary1\ClassLibrary1.csproj", "ClassLibrary1")
.InFile(@"src\ClassLibrary1\Class1.cs", 1, 1)
.OfRule("SA1633", new Uri("https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1633.md"))
.WithPriority(IssuePriority.Warning));
IssueChecker.Check(
issues[3],
IssueBuilder.NewIssue(
"Using directive must appear within a namespace declaration",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProject(@"src\ClassLibrary1\ClassLibrary1.csproj", "ClassLibrary1")
.InFile(@"src\ClassLibrary1\Class1.cs", 1, 1)
.OfRule("SA1200", new Uri("https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1200.md"))
.WithPriority(IssuePriority.Warning));
IssueChecker.Check(
issues[4],
IssueBuilder.NewIssue(
"Using directive must appear within a namespace declaration",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProject(@"src\ClassLibrary1\ClassLibrary1.csproj", "ClassLibrary1")
.InFile(@"src\ClassLibrary1\Class1.cs", 2, 1)
.OfRule("SA1200", new Uri("https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1200.md"))
.WithPriority(IssuePriority.Warning));
IssueChecker.Check(
issues[5],
IssueBuilder.NewIssue(
"Using directive must appear within a namespace declaration",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProject(@"src\ClassLibrary1\ClassLibrary1.csproj", "ClassLibrary1")
.InFile(@"src\ClassLibrary1\Class1.cs", 3, 1)
.OfRule("SA1200", new Uri("https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1200.md"))
.WithPriority(IssuePriority.Warning));
IssueChecker.Check(
issues[6],
IssueBuilder.NewIssue(
"Using directive must appear within a namespace declaration",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProject(@"src\ClassLibrary1\ClassLibrary1.csproj", "ClassLibrary1")
.InFile(@"src\ClassLibrary1\Class1.cs", 4, 1)
.OfRule("SA1200", new Uri("https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1200.md"))
.WithPriority(IssuePriority.Warning));
IssueChecker.Check(
issues[7],
IssueBuilder.NewIssue(
"Using directive must appear within a namespace declaration",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProject(@"src\ClassLibrary1\ClassLibrary1.csproj", "ClassLibrary1")
.InFile(@"src\ClassLibrary1\Class1.cs", 5, 1)
.OfRule("SA1200", new Uri("https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1200.md"))
.WithPriority(IssuePriority.Warning));
IssueChecker.Check(
issues[8],
IssueBuilder.NewIssue(
"Enable XML documentation output",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProject(@"src\ClassLibrary1\ClassLibrary1.csproj", "ClassLibrary1")
.InFile(@"src\ClassLibrary1\Properties\AssemblyInfo.cs", 1, 1)
.OfRule("SA1652", new Uri("https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1652.md"))
.WithPriority(IssuePriority.Warning));
IssueChecker.Check(
issues[9],
IssueBuilder.NewIssue(
"The file header is missing or not located at the top of the file.",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProject(@"src\ClassLibrary1\ClassLibrary1.csproj", "ClassLibrary1")
.InFile(@"src\ClassLibrary1\Properties\AssemblyInfo.cs", 1, 1)
.OfRule("SA1633", new Uri("https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1633.md"))
.WithPriority(IssuePriority.Warning));
IssueChecker.Check(
issues[10],
IssueBuilder.NewIssue(
"Code must not contain trailing whitespace",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProject(@"src\ClassLibrary1\ClassLibrary1.csproj", "ClassLibrary1")
.InFile(@"src\ClassLibrary1\Properties\AssemblyInfo.cs", 5, 77)
.OfRule("SA1028", new Uri("https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1028.md"))
.WithPriority(IssuePriority.Warning));
IssueChecker.Check(
issues[11],
IssueBuilder.NewIssue(
"Code must not contain trailing whitespace",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProject(@"src\ClassLibrary1\ClassLibrary1.csproj", "ClassLibrary1")
.InFile(@"src\ClassLibrary1\Properties\AssemblyInfo.cs", 17, 76)
.OfRule("SA1028", new Uri("https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1028.md"))
.WithPriority(IssuePriority.Warning));
IssueChecker.Check(
issues[12],
IssueBuilder.NewIssue(
"Code must not contain trailing whitespace",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProject(@"src\ClassLibrary1\ClassLibrary1.csproj", "ClassLibrary1")
.InFile(@"src\ClassLibrary1\Properties\AssemblyInfo.cs", 18, 74)
.OfRule("SA1028", new Uri("https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1028.md"))
.WithPriority(IssuePriority.Warning));
IssueChecker.Check(
issues[13],
IssueBuilder.NewIssue(
"Code must not contain trailing whitespace",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProject(@"src\ClassLibrary1\ClassLibrary1.csproj", "ClassLibrary1")
.InFile(@"src\ClassLibrary1\Properties\AssemblyInfo.cs", 28, 22)
.OfRule("SA1028", new Uri("https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1028.md"))
.WithPriority(IssuePriority.Warning));
IssueChecker.Check(
issues[14],
IssueBuilder.NewIssue(
"Code must not contain trailing whitespace",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProject(@"src\ClassLibrary1\ClassLibrary1.csproj", "ClassLibrary1")
.InFile(@"src\ClassLibrary1\Properties\AssemblyInfo.cs", 32, 84)
.OfRule("SA1028", new Uri("https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1028.md"))
.WithPriority(IssuePriority.Warning));
IssueChecker.Check(
issues[15],
IssueBuilder.NewIssue(
"Microsoft.Design : Sign 'ClassLibrary1.dll' with a strong name key.",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProject(@"src\ClassLibrary1\ClassLibrary1.csproj", "ClassLibrary1")
.OfRule("CA2210", new Uri("https://www.google.com/search?q=\"CA2210:\"+site:docs.microsoft.com"))
.WithPriority(IssuePriority.Warning));
IssueChecker.Check(
issues[16],
IssueBuilder.NewIssue(
"Microsoft.Design : Mark 'ClassLibrary1.dll' with CLSCompliant(true) because it exposes externally visible types.",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProject(@"src\ClassLibrary1\ClassLibrary1.csproj", "ClassLibrary1")
.OfRule("CA1014", new Uri("https://www.google.com/search?q=\"CA1014:\"+site:docs.microsoft.com"))
.WithPriority(IssuePriority.Warning));
IssueChecker.Check(
issues[17],
IssueBuilder.NewIssue(
"Microsoft.Performance : The 'this' parameter (or 'Me' in Visual Basic) of 'Class1.Foo()' is never used. Mark the member as static (or Shared in Visual Basic) or use 'this'/'Me' in the method body or at least one property accessor, if appropriate.",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProject(@"src\ClassLibrary1\ClassLibrary1.csproj", "ClassLibrary1")
.InFile(@"src\ClassLibrary1\Class1.cs", 12)
.OfRule("CA1822", new Uri("https://www.google.com/search?q=\"CA1822:\"+site:docs.microsoft.com"))
.WithPriority(IssuePriority.Warning));
IssueChecker.Check(
issues[18],
IssueBuilder.NewIssue(
"Microsoft.Performance : 'Class1.Foo()' declares a variable, 'foo', of type 'string', which is never used or is only assigned to. Use this variable or remove it.",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProject(@"src\ClassLibrary1\ClassLibrary1.csproj", "ClassLibrary1")
.InFile(@"src\ClassLibrary1\Class1.cs", 13)
.OfRule("CA1804", new Uri("https://www.google.com/search?q=\"CA1804:\"+site:docs.microsoft.com"))
.WithPriority(IssuePriority.Warning));
}
[Fact]
public void Should_Read_Issue_With_File_Correct()
{
// Given
var fixture = new MsBuildIssuesProviderFixture<XmlFileLoggerLogFileFormat>("IssueWithFile.xml");
// When
var issues = fixture.ReadIssues().ToList();
// Then
issues.Count.ShouldBe(1);
IssueChecker.Check(
issues.Single(),
IssueBuilder.NewIssue(
@"Microsoft.Usage : 'ConfigurationManager.GetSortedConfigFiles(String)' creates an exception of type 'ApplicationException', an exception type that is not sufficiently specific and should never be raised by user code. If this exception instance might be thrown, use a different exception type.",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProjectOfName(string.Empty)
.InFile(@"src\Cake.Issues.MsBuild.Tests\MsBuildIssuesProviderTests.cs", 1311)
.OfRule("CA2201", new Uri("https://www.google.com/search?q=\"CA2201:\"+site:docs.microsoft.com"))
.WithPriority(IssuePriority.Warning));
}
[Fact]
public void Should_Read_Issue_With_File_Without_Path_Correct()
{
// Given
var fixture = new MsBuildIssuesProviderFixture<XmlFileLoggerLogFileFormat>("IssueWithOnlyFileName.xml");
// When
var issues = fixture.ReadIssues().ToList();
// Then
issues.Count.ShouldBe(1);
IssueChecker.Check(
issues.Single(),
IssueBuilder.NewIssue(
"The variable 'foo' is assigned but its value is never used",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProjectOfName(string.Empty)
.InFile(@"src\Cake.Issues.MsBuild.Tests\MsBuildIssuesProviderTests.cs", 13, 17)
.OfRule("CS0219")
.WithPriority(IssuePriority.Warning));
}
[Fact]
public void Should_Read_Issue_With_Line_Zero_Correct()
{
// Given
var fixture = new MsBuildIssuesProviderFixture<XmlFileLoggerLogFileFormat>("IssueWithLineZero.xml");
// When
var issues = fixture.ReadIssues().ToList();
// Then
issues.Count.ShouldBe(1);
IssueChecker.Check(
issues.Single(),
IssueBuilder.NewIssue(
@"Unable to locate any documentation sources for 'c:\Source\Cake.Prca\Cake.Prca..csproj' (Configuration: Debug Platform: AnyCPU)",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProject("Cake.Prca.shfbproj", "Cake.Prca")
.InFile("SHFB")
.OfRule("BE0006")
.WithPriority(IssuePriority.Warning));
}
[Fact]
public void Should_Read_Issue_Without_File_Correct()
{
// Given
var fixture = new MsBuildIssuesProviderFixture<XmlFileLoggerLogFileFormat>("IssueWithoutFile.xml");
// When
var issues = fixture.ReadIssues().ToList();
// Then
issues.Count.ShouldBe(1);
IssueChecker.Check(
issues.Single(),
IssueBuilder.NewIssue(
"Microsoft.Naming : Rename type name 'UniqueQueue(Of T)' so that it does not end in 'Queue'.",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProjectOfName(string.Empty)
.OfRule("CA1711", new Uri("https://www.google.com/search?q=\"CA1711:\"+site:docs.microsoft.com"))
.WithPriority(IssuePriority.Warning));
}
[Fact]
public void Should_Read_Issue_Without_Code_Correct()
{
// Given
var fixture = new MsBuildIssuesProviderFixture<XmlFileLoggerLogFileFormat>("IssueWithoutCode.xml");
// When
var issues = fixture.ReadIssues().ToList();
// Then
issues.Count.ShouldBe(1);
IssueChecker.Check(
issues.Single(),
IssueBuilder.NewIssue(
"SA1300 : CSharp.Naming : namespace names begin with an upper-case letter: foo.",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProjectOfName(string.Empty)
.InFile(@"src\Cake.Issues.MsBuild.Tests\MsBuildIssuesProviderTests.cs", 21, 1)
.WithPriority(IssuePriority.Warning));
}
[Fact]
public void Should_Ignore_Issue_Without_Message()
{
// Given
var fixture = new MsBuildIssuesProviderFixture<XmlFileLoggerLogFileFormat>("IssueWithoutMessage.xml");
// When
var issues = fixture.ReadIssues().ToList();
// Then
issues.Count.ShouldBe(0);
}
[Fact]
public void Should_Filter_Control_Chars_From_Log_Content()
{
// Given
var fixture = new MsBuildIssuesProviderFixture<XmlFileLoggerLogFileFormat>("LogWithControlChars.xml");
// When
var issues = fixture.ReadIssues().ToList();
// Then
issues.Count.ShouldBe(0);
}
[Fact]
public void Should_Read_Issue_With_Absolute_FileName_And_Without_Task()
{
var fixture = new MsBuildIssuesProviderFixture<XmlFileLoggerLogFileFormat>("IssueWithAbsoluteFileNameAndWithoutTask.xml");
var repoRootCreated = !Directory.Exists(fixture.ReadIssuesSettings.RepositoryRoot.FullPath);
Directory.CreateDirectory(fixture.ReadIssuesSettings.RepositoryRoot.FullPath);
try
{
var oldWorkingDirectory = Directory.GetCurrentDirectory();
try
{
Directory.SetCurrentDirectory(fixture.ReadIssuesSettings.RepositoryRoot.FullPath);
// When
var issues = fixture.ReadIssues().ToList();
// Then
issues.Count.ShouldBe(1);
}
finally
{
Directory.SetCurrentDirectory(oldWorkingDirectory);
}
}
finally
{
if (repoRootCreated)
{
Directory.Delete(fixture.ReadIssuesSettings.RepositoryRoot.FullPath);
}
}
}
[Fact]
public void Should_Read_Errors()
{
// Given
var fixture = new MsBuildIssuesProviderFixture<XmlFileLoggerLogFileFormat>("IssueWithError.xml");
// When
var issues = fixture.ReadIssues().ToList();
// Then
issues.Count.ShouldBe(1);
IssueChecker.Check(
issues[0],
IssueBuilder.NewIssue(
@"'ConfigurationManager.GetSortedConfigFiles(String)': not all code paths return a value",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProjectOfName(string.Empty)
.InFile(@"src\Cake.Issues.MsBuild.Tests\MsBuildIssuesProviderTests.cs", 1311)
.OfRule("CS0161")
.WithPriority(IssuePriority.Error));
}
[Fact]
public void Should_Read_Both_Warnings_And_Errors()
{
// Given
var fixture = new MsBuildIssuesProviderFixture<XmlFileLoggerLogFileFormat>("IssueWithBothWarningAndErrors.xml");
// When
var issues = fixture.ReadIssues().ToList();
// Then
issues.Count.ShouldBe(2);
IssueChecker.Check(
issues[0],
IssueBuilder.NewIssue(
@"Microsoft.Usage : 'ConfigurationManager.GetSortedConfigFiles(String)' creates an exception of type 'ApplicationException', an exception type that is not sufficiently specific and should never be raised by user code. If this exception instance might be thrown, use a different exception type.",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProjectOfName(string.Empty)
.InFile(@"src\Cake.Issues.MsBuild.Tests\MsBuildIssuesProviderTests.cs", 1311)
.OfRule("CA2201", new Uri("https://www.google.com/search?q=\"CA2201:\"+site:docs.microsoft.com"))
.WithPriority(IssuePriority.Warning));
IssueChecker.Check(
issues[1],
IssueBuilder.NewIssue(
@"'ConfigurationManager.GetSortedConfigFiles(String)': not all code paths return a value",
"Cake.Issues.MsBuild.MsBuildIssuesProvider",
"MSBuild")
.InProjectOfName(string.Empty)
.InFile(@"src\Cake.Issues.MsBuild.Tests\MsBuildIssuesProviderTests.cs", 1311)
.OfRule("CS0161")
.WithPriority(IssuePriority.Error));
}
}
}
}