Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USD $0? #1139

Open
seniorm0ment opened this issue Oct 20, 2023 · 5 comments
Open

USD $0? #1139

seniorm0ment opened this issue Oct 20, 2023 · 5 comments

Comments

@seniorm0ment
Copy link

In my BTC wallet, it looks like it is not converting my balance to show the USD amount. It just shows $0USD

Also why not show the current price BTC is at below, as well as maybe a little help icon that shows the formulate for the calculation if someone was unsure and wanted to know they could just click that.
Nice quality of life feature.

So much wasted space in the wallet screen..

@TruncatedPi
Copy link

On Android I also get this for all my wallets for all currencies that I tried - not just for balance, but also for all historical transactions.
I noticed the issue today on a previous version of Cake Wallet for Android. Updating to this latest version (and even restarting) did not resolve the issue.

@tuxpizza
Copy link
Collaborator

tuxpizza commented Dec 6, 2023

Closing since this was back when we were having an issue with our Price API. No issues have occurred since then.

@tuxpizza tuxpizza closed this as completed Dec 6, 2023
@nahuhh
Copy link

nahuhh commented Dec 8, 2023

Its a regular occuring thing.
obviously(?) a race issue

@tuxpizza
Copy link
Collaborator

tuxpizza commented Dec 8, 2023

Regularly occurring? How often exactly. And how does it manifest, sometimes it doesn't show the price, or sometimes it takes forever to show the price, does force closing the app fix the issue?
And is this just an issue with BTC wallet or other wallets like Monero?

@nahuhh
Copy link

nahuhh commented Dec 8, 2023

Regularly occurring? How often exactly.

Multiple times per day.

And how does it manifest, sometimes it doesn't show the price, or sometimes it takes forever to show the price,

Will not show the price at all until restarting the app

does force closing the app fix the issue?

Simply closing and opening fixes

And is this just an issue with BTC wallet or other wallets like Monero?

i only use xmr

The issue is worse when set to "tor only".

what i think might fix:
a) Adding a delay between starting app and requesting rates.
b) instead of only pulling the selected exchange rate, pull all of them and do the selection locally
b2) might need a delay

i think its likely not able to "check" what the selected fiat is before sending the request.

i did NOT do any traffic analysis to confirm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants