Skip to content
This repository has been archived by the owner on Jun 13, 2022. It is now read-only.

Add hook to grammar change #136

Closed
StaticRocket opened this issue Mar 6, 2018 · 3 comments
Closed

Add hook to grammar change #136

StaticRocket opened this issue Mar 6, 2018 · 3 comments
Labels

Comments

@StaticRocket
Copy link

Script a toolbar refresh to occur when the tab grammar is changed so single tab projects get their required toolbar without having the user make a new tab, switch to it, and switch back to refresh the toolbar manually.

Based on the issue I have when I change the grammar the toolbar does not update to show grammar specific buttons until I switch to another tab and switch back. If this is already a feature, sorry for the pointless request. If it is a bug and it should be updating immediately any help is appreciated.

@StaticRocket StaticRocket changed the title Add hook to grammar change[enhancement] Add hook to grammar change [enhancement] Mar 6, 2018
@UziTech UziTech added the bug label Mar 6, 2018
@StaticRocket
Copy link
Author

StaticRocket commented Mar 7, 2018

It may also be worth mentioning that the buttons disappear if one clicks on any side panels, such as the project explorer or git panels. This occurs with or without "Persistent Project Tool Bar" being toggled.

@StaticRocket StaticRocket changed the title Add hook to grammar change [enhancement] Add hook to grammar change Mar 7, 2018
@UziTech
Copy link
Collaborator

UziTech commented Mar 7, 2018

If the button is set to show: "Some Grammar" than clicking on a side panel will change the grammar to null and hide the button since the active item changed to the panel that you clicked on. This is the intended behavior.

Some panels, like the find/replace panel, won't change the active item so the grammar should not change.

Changing the grammar should be working in the newest release. If you still think the buttons disappearing is a bug please open a new issue.

@UziTech UziTech closed this as completed Mar 7, 2018
@StaticRocket
Copy link
Author

Right, I had suspected it was grabbing null grammer from side panels. I suppose it isn't that much of a problem, I just need to be aware of moving elements. Good job patching the original ticket issue, I will be testing that soon enough.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants