Issue/69 fix zend diactoros uri #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@steinkel can you check this PR? Thank you! |
|
Checking this one ASAP, thank you for the heads up |
|
Thanks @ajibarra ! 👍🏻 |
|
Thank you for the review ! |
|
@ajibarra Can you merge it into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace Zend\Diactoros\Uri imports by Laminas\Diactoros\Uri to fix the following issues :
#69
CakeDC/users#997
Since CakePHP is using Laminas namespaces I don't see any drawbacks to use it as well in the plugin
https://github.com/cakephp/cakephp/blob/4.x/composer.json#L31
Moreover the Zend Diactoros repository is abandoned since the end of 2019.
This is my first contribution, let me know if I've made something wrong.