Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.x Always quote SELECT identifier for Oracle #55

Closed
jmbIFR opened this issue Sep 22, 2020 · 1 comment
Closed

5.x Always quote SELECT identifier for Oracle #55

jmbIFR opened this issue Sep 22, 2020 · 1 comment

Comments

@jmbIFR
Copy link

jmbIFR commented Sep 22, 2020

Oracle auto converts unquoted identifiers to upper case.
Unquoted select aliases brake the cakePHP camelCase table Alias.

cakePHP commit cakephp/cakephp@4949b72 "Quote SELECT identifiers only if autoquoting is enabled."

The postgres driver is modified to always apply select aliases cakephp/cakephp@49608e9#diff-e71e42d8a65ac8e52edc9657223c9f8c Always quote SELECT identifier for Postgres.

The Oracle driver need the same modification as the postgres driver
@jmbIFR jmbIFR mentioned this issue Sep 22, 2020
Closed
@skie
Copy link
Member

skie commented Dec 6, 2021

merged pr #56

@skie skie closed this as completed Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skie @jmbIFR