Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SessionAuthenticator identify option does not work. #150

Closed
robertpustulka opened this issue Nov 29, 2017 · 2 comments
Closed

SessionAuthenticator identify option does not work. #150

robertpustulka opened this issue Nov 29, 2017 · 2 comments
Labels
Milestone

Comments

@robertpustulka
Copy link
Member

robertpustulka commented Nov 29, 2017

I set up authentication as below:

    public function authentication(AuthenticationServiceInterface $authentication)
    {
        $authentication->loadIdentifier('Authentication.Password');

        $authentication->loadAuthenticator('Authentication.Session', [
            'identify' => true
        ]);
        $authentication->loadAuthenticator('Authentication.Form');

        return $authentication;
    }

Identity verification won't work. SessionAuthenticator assumes that the data persisted in session provides a plain text password: https://github.com/cakephp/authentication/blob/master/src/Authenticator/SessionAuthenticator.php#L60-L63

We need an alternative approach to reidentify the identity since we can't expect that stored identity data will provide plain text password for identifiers.

This will be needed for the CookieAuthenticator as well.

@robertpustulka robertpustulka added this to the 1.0.0 milestone Nov 29, 2017
@robertpustulka
Copy link
Member Author

I was wondering if we could have a simple IdIdentifier for identity reverification?

This way persistence authenticators could check if an identity with given id still exist in a database (isn't banned or something).

@robertpustulka
Copy link
Member Author

Resolved as a part of #153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant