Call getDataSource() instead of the directly calling

ConnectionManager::getDataSource().
cakephp · Nov 12, 2013 · 52d4257 · 52d4257
1 parent c1f3d9c
commit 52d4257
Showing 1 changed file with 6 additions and 16 deletions.
diff --git a/lib/Cake/Model/Datasource/DboSource.php b/lib/Cake/Model/Datasource/DboSource.php
@@ -1117,20 +1117,16 @@ public function read(Model $Model, $queryData = array(), $recursive = null) {
 					$LinkModel = $Model->{$assoc};
 
 					if (!isset($linkedModels[$type . '/' . $assoc])) {
-						if ($Model->useDbConfig === $LinkModel->useDbConfig) {
+						$db = $Model->useDbConfig === $LinkModel->useDbConfig ? $this : $LinkModel->getDataSource();
-							$db = $this;
-						} else {
-							$db = ConnectionManager::getDataSource($LinkModel->useDbConfig);
-						}
 					} elseif ($Model->recursive > 1) {
 						$db = $this;
 					}
 
 					if (isset($db) && method_exists($db, 'queryAssociation')) {
 						$stack = array($assoc);
 						$stack['_joined'] = $joined;
+
 						$db->queryAssociation($Model, $LinkModel, $type, $assoc, $assocData, $array, true, $resultSet, $Model->recursive - 1, $stack);
-						unset($db);
 
 						if ($type === 'hasMany' || $type === 'hasAndBelongsToMany') {
 							$filtered[] = $assoc;
@@ -1246,11 +1242,7 @@ public function queryAssociation(Model $Model, &$LinkModel, $type, $association,
 						$tmpStack = $stack;
 						$tmpStack[] = $assoc1;
 
-						if ($LinkModel->useDbConfig === $DeepModel->useDbConfig) {
+						$db = $LinkModel->useDbConfig === $DeepModel->useDbConfig ? $this : $DeepModel->getDataSource();
-							$db = $this;
-						} else {
-							$db = ConnectionManager::getDataSource($DeepModel->useDbConfig);
-						}
 
 						$db->queryAssociation($LinkModel, $DeepModel, $type1, $assoc1, $assocData1, $queryData, true, $fetch, $recursive - 1, $tmpStack);
 					}
@@ -1331,11 +1323,9 @@ public function queryAssociation(Model $Model, &$LinkModel, $type, $association,
 							if ($type1 === 'belongsTo' || ($DeepModel->alias === $modelAlias && $type === 'belongsTo') || ($DeepModel->alias !== $modelAlias)) {
 								$tmpStack = $stack;
 								$tmpStack[] = $assoc1;
-								if ($LinkModel->useDbConfig == $DeepModel->useDbConfig) {
+
-									$db = $this;
+								$db = $LinkModel->useDbConfig === $DeepModel->useDbConfig ? $this : $DeepModel->getDataSource();
-								} else {
+
-									$db = ConnectionManager::getDataSource($DeepModel->useDbConfig);
-								}
 								$db->queryAssociation($LinkModel, $DeepModel, $type1, $assoc1, $assocData1, $queryData, true, $fetch, $recursive - 1, $tmpStack);
 							}
 						}