Throw exception when selected serializer is not installed

cakephp · Sep 18, 2013 · 5d509e2 · 5d509e2
1 parent bd3f005
commit 5d509e2
Show file tree

Hide file tree

Showing 2 changed files with 60 additions and 2 deletions.
diff --git a/lib/Cake/Cache/Engine/MemcachedEngine.php b/lib/Cake/Cache/Engine/MemcachedEngine.php
@@ -143,11 +143,19 @@ protected function _setOptions() {
 			case 'igbinary':
 				if (Memcached::HAVE_IGBINARY) {
 					$serializer = self::$serializer['igbinary'];
+				} else {
+					throw new CacheException(
+						__d('cake_dev', 'Memcached extension is not compiled with igbinary support')
+					);
 				}
 				break;
 			case 'json':
 				if (Memcached::HAVE_JSON) {
 					$serializer = self::$serializer['json'];
+				} else {
+					throw new CacheException(
+						__d('cake_dev', 'Memcached extension is not compiled with json support')
+					);
 				}
 				break;
 		}

diff --git a/lib/Cake/Test/Case/Cache/Engine/MemcachedEngineTest.php b/lib/Cake/Test/Case/Cache/Engine/MemcachedEngineTest.php
@@ -172,7 +172,7 @@ public function testPhpSerializerSetting() {
 	}
 
 /**
- * testPhpSerializerSetting method
+ * testJsonSerializerSetting method
  *
  * @return void
  */
@@ -195,7 +195,7 @@ public function testJsonSerializerSetting() {
 	}
 
 /**
- * testPhpSerializerSetting method
+ * testIgbinarySerializerSetting method
  *
  * @return void
  */
@@ -217,6 +217,56 @@ public function testIgbinarySerializerSetting() {
 		$this->assertEquals(Memcached::SERIALIZER_IGBINARY, $Memcached->getMemcached()->getOption(Memcached::OPT_SERIALIZER));
 	}
 
+/**
+ * testJsonSerializerThrowException method
+ *
+ * @return void
+ */
+	public function testJsonSerializerThrowException() {
+		$this->skipIf(
+			Memcached::HAVE_JSON,
+			'Memcached extension is compiled with json support'
+		);
+
+		$Memcached = new TestMemcachedEngine();
+		$settings = array(
+			'engine' => 'Memcached',
+			'servers' => array('127.0.0.1:11211'),
+			'persistent' => false,
+			'serializer' => 'json'
+		);
+
+		$this->setExpectedException(
+			'CacheException', 'Memcached extension is not compiled with json support'
+		);
+		$Memcached->init($settings);
+	}
+
+/**
+ * testIgbinarySerializerThrowException method
+ *
+ * @return void
+ */
+	public function testIgbinarySerializerThrowException() {
+		$this->skipIf(
+			Memcached::HAVE_IGBINARY,
+			'Memcached extension is compiled with igbinary support'
+		);
+
+		$Memcached = new TestMemcachedEngine();
+		$settings = array(
+			'engine' => 'Memcached',
+			'servers' => array('127.0.0.1:11211'),
+			'persistent' => false,
+			'serializer' => 'igbinary'
+		);
+
+		$this->setExpectedException(
+			'CacheException', 'Memcached extension is not compiled with igbinary support'
+		);
+		$Memcached->init($settings);
+	}
+
 /**
  * test using authentication without memcached installed with SASL support
  * throw an exception