Fixing callback naming issues with mootools

cakephp · Mar 28, 2009 · 977efe4 · 977efe4
1 parent 29b3a96
commit 977efe4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/cake/libs/view/helpers/mootools_engine.php b/cake/libs/view/helpers/mootools_engine.php
@@ -44,6 +44,9 @@ class MootoolsEngineHelper extends JsBaseEngineHelper {
 		'sortable' => array(
 			'distance' => 'snap',
 			'containment' => 'constrain',
+			'sort' => 'onSort',
+			'complete' => 'onComplete',
+			'start' => 'onStart',
 		)
 	);
 /**
@@ -198,7 +201,7 @@ function request($url, $options = array()) {
  **/
 	function sortable($options = array()) {
 		$options = $this->_mapOptions('sortable', $options);
-		$callbacks = array('start', 'sort', 'complete');
+		$callbacks = array('onStart', 'onSort', 'onComplete');
 		$options = $this->_parseOptions($options, $callbacks);
 		return 'var mooSortable = new Sortables(' . $this->selection . ', {' . $options . '});';
 	}

diff --git a/cake/tests/cases/libs/view/helpers/mootools_engine.test.php b/cake/tests/cases/libs/view/helpers/mootools_engine.test.php
@@ -184,7 +184,7 @@ function testSortable() {
 			'complete' => 'onStop',
 			'sort' => 'onSort',
 		));
-		$expected = 'var mooSortable = new Sortables($("myList"), {start:onStart, complete:onStop, sort:onSort, snap:5, constrain:"parent"});';
+		$expected = 'var mooSortable = new Sortables($("myList"), {constrain:"parent", onComplete:onStop, onSort:onSort, onStart:onStart, snap:5});';
 		$this->assertEqual($result, $expected);
 	}
 }