fix double-encoding of external urls

cakephp · Jun 12, 2012 · b32edfe · b32edfe
1 parent 5f0e096
commit b32edfe
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/Cake/Test/Case/View/Helper/HtmlHelperTest.php b/lib/Cake/Test/Case/View/Helper/HtmlHelperTest.php
@@ -333,6 +333,10 @@ public function testLink() {
 			'/a'
 		);
 		$this->assertTags($result, $expected);
+
+		$result = $this->Html->link('http://www.example.org?param1=value1&param2=value2');
+		$expected = array('a' => array('href' => 'http://www.example.org?param1=value1&amp;param2=value2'), 'http://www.example.org?param1=value1&amp;param2=value2', '/a');
+		$this->assertTags($result, $expected);
 	}
 
 /**

diff --git a/lib/Cake/View/Helper/HtmlHelper.php b/lib/Cake/View/Helper/HtmlHelper.php
@@ -335,7 +335,8 @@ public function link($title, $url = null, $options = array(), $confirmMessage =
 			$url = $this->url($url);
 		} else {
 			$url = $this->url($title);
-			$title = h(urldecode($url));
+			$title = htmlspecialchars_decode($url, ENT_QUOTES);
+			$title = h(urldecode($title));
 			$escapeTitle = false;
 		}