Decided to make supportsQuoting not abstract, as most of drivers do

support this operation
cakephp · Feb 3, 2013 · f306db3 · f306db3
1 parent 4475b21
commit f306db3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/Cake/Model/Datasource/Database/Driver.php b/lib/Cake/Model/Datasource/Database/Driver.php
@@ -124,7 +124,9 @@ public abstract function quote($value, $type);
  *
  * @return boolean
  **/
-	public abstract function supportsQuoting();
+	public function supportsQuoting() {
+		return true;
+	}
 
 /**
  * Returns last id generated for a table or sequence in database

diff --git a/lib/Cake/Model/Datasource/Database/Query.php b/lib/Cake/Model/Datasource/Database/Query.php
@@ -471,6 +471,9 @@ public function _buildFromPart($parts) {
  *			'table' => 'products', 'type' => 'INNER', 'conditions' => 'a.owner_id = p.id
  *		]
  *	]);
+ *	// LEFT JOIN authors a ON (a.id = b.author_id)
+ *	// INNER JOIN products p (a.owner_id = p.id)
+ * }}
  *
  * ## Using conditions and types
  *