Skip to content

Commit

Permalink
Update documentation and typehint.
Browse files Browse the repository at this point in the history
  • Loading branch information
bar committed Dec 22, 2013
1 parent 0c4a5c5 commit f30b43b
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions lib/Cake/Model/Datasource/DboSource.php
Expand Up @@ -1437,15 +1437,17 @@ protected function _fetchHasAndBelongsToMany(Model $Model, $query, $ids, $associ
} }


/** /**
* Merge the results of hasMany relations. * Merge the results of 'hasMany' associations.
*
* Note: this function also deals with the formatting of the data.
* *
* @param array $resultSet Data to merge into. * @param array $resultSet Data to merge into.
* @param array $merge Data to merge. * @param array $assocResultSet Data to merge.
* @param string $association Name of Model being merged. * @param string $association Name of Model being merged.
* @param Model $Model Model being merged onto. * @param Model $Model Model being merged onto.
* @return void * @return void
*/ */
protected function _mergeHasMany(&$resultSet, $merge, $association, $Model) { protected function _mergeHasMany(&$resultSet, $assocResultSet, $association, Model $Model) {
$modelAlias = $Model->alias; $modelAlias = $Model->alias;
$primaryKey = $Model->primaryKey; $primaryKey = $Model->primaryKey;
$foreignKey = $Model->hasMany[$association]['foreignKey']; $foreignKey = $Model->hasMany[$association]['foreignKey'];
Expand All @@ -1458,7 +1460,7 @@ protected function _mergeHasMany(&$resultSet, $merge, $association, $Model) {
$resultPrimaryKey = $result[$modelAlias][$primaryKey]; $resultPrimaryKey = $result[$modelAlias][$primaryKey];


$merged = array(); $merged = array();
foreach ($merge as $data) { foreach ($assocResultSet as $data) {
if ($resultPrimaryKey !== $data[$association][$foreignKey]) { if ($resultPrimaryKey !== $data[$association][$foreignKey]) {
continue; continue;
} }
Expand Down Expand Up @@ -1637,7 +1639,7 @@ public function buildAssociationQuery(Model $Model, $queryData) {
* @param boolean $external Whether or not the association query is on an external datasource. * @param boolean $external Whether or not the association query is on an external datasource.
* @return mixed * @return mixed
* String representing a query. * String representing a query.
* True. when $external is false and association $type is 'hasOne' or 'belongsTo'. * True, when $external is false and association $type is 'hasOne' or 'belongsTo'.
*/ */
public function generateAssociationQuery(Model $Model, Model $LinkModel, $type, $association, $assocData, &$queryData, $external) { public function generateAssociationQuery(Model $Model, Model $LinkModel, $type, $association, $assocData, &$queryData, $external) {
$assocData = $this->_scrubQueryData($assocData); $assocData = $this->_scrubQueryData($assocData);
Expand Down

0 comments on commit f30b43b

Please sign in to comment.