Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split combined getter/setter EntityInterface::isNew() #13454

Closed
ADmad opened this issue Aug 1, 2019 · 3 comments
Closed

Split combined getter/setter EntityInterface::isNew() #13454

ADmad opened this issue Aug 1, 2019 · 3 comments
Labels
database deprecations enhancement ORM
Milestone
4.0.0

Comments

@ADmad
Copy link
Member

ADmad commented Aug 1, 2019

Should we add a new method EntityInterface::setNew(bool $new) and change isNew() to EntityInterface::isNew(): bool?
@ADmad ADmad added this to the 4.0.0 milestone Aug 1, 2019
@markstory
Copy link
Member

Makes sense. Could we keep compatibility with a deprecation warning to avoid yet another 3.x release?

@ADmad
Copy link
Member Author

ADmad commented Aug 2, 2019

Yup we can, I'll whip up a PR soon.

@ADmad ADmad mentioned this issue Aug 2, 2019
Merged
@ADmad ADmad closed this as completed Aug 2, 2019
@robertpustulka
Copy link
Member

Should this be backported to 3.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
database deprecations enhancement ORM
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
4 participants
@markstory @ADmad @ravage84 @robertpustulka