Extending base validation fails.

[dereuromark]

Description

It should be possible to use a different (extended) Validation class for all validators
https://book.cakephp.org/5/en/core-libraries/validation.html#adding-validation-providers

As per book in bootstrap:

// replacing core one with app
\Cake\Validation\Validator::addDefaultProvider('default', \App\Validation\Validation::class);

leads to

[TypeError] Cake\Validation\Validation::decimal(): Argument # 3 ($regex) must be of type ?string, array given

But it is just

namespace App\Validation;

use Cake\Validation\Validation as CakeValidation;

class Validation extends CakeValidation {}

CakePHP Version

5.0

PHP Version

8.2

[dereuromark]

The whole validation thing in Cake is quite buggy, as pointed out earlier ( #12697 ).
It doesn't help that the argument count can vary, and context can be at any position of validation rules, depending on what other arguments are available.

As soon as the validation provider is configured in any way, even core rules fail with the above.

The main reason seems to be that in this case, the 3rd arg is set with this array instead as $context instead of the expected $regex:

[
'newRecord' => false,
'data' => [
    ...
],
'field' => 'weight',
'providers' => [ ],
]

[dereuromark]

My guess would be that because ?string $regexp = null is an optional value, and possibly null here
that it messes up the count when passing them in

if ($this->_pass) {
            $args = array_values(array_merge([$value], $this->_pass, [$context]));
            $result = $callable(...$args);
        } else {
            $result = $callable($value, $context);
        }
if ($this->_pass) {
            $args = array_values(array_merge([$value], $this->_pass, [$context]));
            $result = $callable(...$args);
        } else {
            $result = $callable($value, $context);
        }