Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0 - Consistent use of short array syntax #1985

Closed
ghost opened this issue Oct 11, 2013 · 8 comments
Closed

3.0 - Consistent use of short array syntax #1985

ghost opened this issue Oct 11, 2013 · 8 comments
Milestone

Comments

@ghost
Copy link

ghost commented Oct 11, 2013

Created by James Hall, 25th Aug 2012. (originally Lighthouse ticket #3150):


It's already used in lib/Cake/Core/Object.php

I'll submit a pull request shortly.

@ghost
Copy link
Author

ghost commented Oct 11, 2013

25th Aug 2012, Mark Story said:


There are over 26000 calls to array() in CakePHP. Changing all of them now will make merges between 2.x and 3.x very painful. We're postponing this until after the first release of 3.0.0 as the merge pain alone is not worth it.

@ghost
Copy link
Author

ghost commented Oct 11, 2013

25th Aug 2012, James Hall said:


That's a fair point.

@cameri
Copy link
Contributor

cameri commented Oct 29, 2013

Do we also want the new array syntax in baked models,controllers,etc.?

@dereuromark
Copy link
Member

Since Cake3 will be >= 5.4 this makes sense.

@cameri
Copy link
Contributor

cameri commented Oct 30, 2013

I'm holding it here folks, at least until 3.0 is out.

@markstory
Copy link
Member

Thanks for the help on this so far. I agree it will be easier to do once 3.0.0 comes out.

@josephzidell
Copy link

@dereuromark
Copy link
Member

Closing as this will be the case once 3.0.0 comes out.

We can use ConvertShell, as well:

cake Upgrade.Convert arrays /path/to/core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants