3.0 - Extend DateTime to add a __toString and use that class instead when hydrating

[lorenzo]

According to some feedback I've got for 3.0-dev, doing echo $entity->created; throws an exception since the date object cannot be converted to string. Creating a class that extends DateTime and adding a __toString method to it will solve this issue and make the views more visually appealing.

We may consider adding some formatting shortcuts to it too.

[jippi]

Sounds like CakeTime :)

[lorenzo]

Only that CakeTime does not extend DateTime and all the methods are static.

[jippi]

I'm aware, but imo it would make sense to make CakeTime extend DateTime and make methods non static where it makes sense. e.g. TimeAgoInWords and all those do need to be static, they need a time anyway :)

some of the methods can remain static, while other might as well work on an instance :)

[markstory]

How would someone set the default format for this class?

[jippi]

like today, either make them remain static or by passing it in through the constructor / set method

[lorenzo]

@markstory Im thinking of using the Type system. You could do Type::build('date')->setDefaultFormat('Y-m-d') static properties and Entity getters are the other options

[markstory]

@jippi I kind of like having Cake\Utility\Time be an extension of DateTime. I bet there are some interesting ideas hidden in doing that.

[bcrowe]

After looking into / beginning to have Time extend DateTime, I wasn't seeing much value. For the most part, it's all static methods and there isn't much value outside of not having to instantiate a DateTime object inside of these methods. In my experiences, Time's role is primarily serving as the engine for the TimeHelper. (That's subject to myself though.) That being said, after bouncing this off of @markstory, he suggested having the ORM returning an improved DateTime object for datetime fields. Ex: $post->created->timeAgoInWords();

Mark, please chime in if I've overlooked or misunderstood anything.

[markstory]

Nope that was my thinking too. This would also allow us to provide a useful __toString() method allowing <?= $post->created; ?> to do something useful.

[lorenzo]

Maybe we can just use an external lib for this? https://github.com/briannesbitt/Carbon

[markstory]

Using carbon might save us a bunch of time and effort. It has a pretty nice interface and the testing features are a bonus.

[lorenzo]

Yeah, I particularly like the testing features which would solve one the nightmares from 2.x

[jippi]

👍 for Carbon :=)

[markstory]

Not only does it scratch our own itch, but it sets up application developers better as well. They too can benefit for the easier testing that carbon provides.

[markstory]

Can this be closed with the Carbon dependency being used now?

[lorenzo]

Yes