3.0 ORM Using count before all

[Laykou]

Using count() before all() or any iterator doesn't bind associations:

// Doesn't work
$query = $articles->contain(['Categories'])->hydrate(false);
$total = $query->count();
foreach ($query as $article) {
  $article['category']; // is empty
}

// Works
$query = $articles->contain(['Categories'])->hydrate(false);
foreach ($query as $article) {
  $article['category']; // is ok
}
$total = $query->count();

Was there recently any change in the count() method? The pagination triggers all() before count() therefore it works properly.

[lorenzo]

@markstory it must be the new autoFields thing

[markstory]

It very well could be. @Laykou count() recently changed so that in unbinds all the fields from a query to avoid loading additional fields that are not needed for the count. However, that change was done to a 'clean' copy. Perhaps the copy is still sharing an eagerloader instance.

[markusramsak]

I solved this in #6013

[markusramsak]

@Laykou
This problem occurs when you try to execute a count- and then an all-query with the same instance because when executing count then all associated fields are removed therefore they have to be restored.

// this would work because no extra count select would be executed
$query = $articles->contain(['Categories'])->hydrate(false)->all();
$total = $query->count();
foreach ($query as $article) {
  $article['category']; // NOT empty
}

[Laykou]

Great, thanks @mdlouhy for the fix, I see what was the problem.
@markstory I discovered that it is how PHP works, it only copies the standard variable types:

When an object is cloned, PHP 5 will perform a shallow copy of all of the object's properties.
Any properties that are references to other variables, will remain references.

Closing this as the #6013 is open. @mdlouhy please add tests.

[Laykou]

Just for the record the issue was solved in #6019