Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Broken with cakephp 3.6 #47

Open
icex opened this issue Aug 17, 2018 · 5 comments
Open

Broken with cakephp 3.6 #47

icex opened this issue Aug 17, 2018 · 5 comments

Comments

@icex
Copy link

icex commented Aug 17, 2018

I recently upgraded to cake 3.6 and all my tests are broken.

  • Routes are not loaded at runtime, amOnRoute cannot be used(nothing is found). [Cake\Routing\Exception\MissingRouteException] A route matching "array (...
  • Router::reload(); in reloadRoutes can result in 'duplicate routes' errors. see Plugin routes config files are included twice app#593
  • Lots of deprecated errors. Event::$data is deprecated. Use Event::getData() instead. eventManager() is deprecated. Use getEventManager()/setEventManager() instead. etc..
@lorenzo
Copy link
Member

lorenzo commented Aug 17, 2018

Would you like to send a pull request with the fix for this issue?

@icex
Copy link
Author

icex commented Aug 17, 2018

Hi, working on it :)

@dereuromark
Copy link
Member

dereuromark commented Aug 17, 2018

Also note that "Lots of deprecated errors" doesnt mean broken. It can and should then just be silenced.
It is good to support more than just the latest minor if possible here anyway.
Only force ^3.6 as dependency here if really necessary and one is forced to use a new method that is only available in this new minor.

@lorenzo
Copy link
Member

lorenzo commented Aug 17, 2018

@icex Thanks so much!

@icex
Copy link
Author

icex commented Aug 20, 2018

I have got it working on my branch (only for the latest version of cake, it should be 4.x ready)
https://github.com/icex/codeception

I'll submit a PR after more testing and add back support for older versions

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants