Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psr/log dependency update #2055

Closed
macwinnie opened this issue Jan 2, 2022 · 3 comments
Closed

psr/log dependency update #2055

macwinnie opened this issue Jan 2, 2022 · 3 comments

Comments

@macwinnie
Copy link

Hi,

I wanted to implement migrations in a small of my projects – and recently encountered that the dependency psr/log runs behind the current version(s):

Updating dependencies
Lock file operations: 17 installs, 1 update, 0 removals
...
  - Downgrading psr/log (3.0.0 => 1.1.4)
...

Is there a path to update dependencies within Phinx?

Thanks a lot
macwinnie

@LordSimal
Copy link
Contributor

LordSimal commented Jan 2, 2022

It seems like cakephp/datasource (which is a synonym for cakephp/cakephp as you see here ) requires psr/log ^1.1

-> % composer why -t psr/log
psr/log 1.1.4 Common interface for logging libraries
├──cakephp/datasource 4.3.3 (requires psr/log ^1.1)
│  └──cakephp/database 4.3.3 (requires cakephp/datasource ^4.0)
│     └──robmorgan/phinx 0.12.9 (requires cakephp/database ^4.0)
│        └──__root__ (requires robmorgan/phinx ^0.12.9)
└──symfony/console v5.4.2 (conflicts psr/log >=3) (circular dependency aborted here)

@LordSimal
Copy link
Contributor

LordSimal commented Jan 2, 2022

You will be able to use psr/log v3 when CakePHP 5 is released. See https://github.com/cakephp/cakephp/blob/5.x/composer.json#L37

Basically the return types added in v3 prevent us to upgrade current CakePHP 4 because currently we return the instance it is used in (see https://github.com/cakephp/cakephp/blob/4.x/src/Database/Connection.php#L882)

But v3 requires a void return type which breaks functionality in CakePHP 4.

@MasterOdin
Copy link
Member

Closing this issue as it's not really something phinx can "fix" as it's blocked by upstream. You can voice support for #1754 to make cakephp/database an optional dependency which would solve this assuming you don't use the query builder interface.

@MasterOdin MasterOdin changed the title Dependency update psr/log dependency update Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants