Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all templates are being detected #25

Open
calebsmith opened this issue Jul 11, 2014 · 2 comments
Open

Not all templates are being detected #25

calebsmith opened this issue Jul 11, 2014 · 2 comments
Labels

Comments

@calebsmith
Copy link
Contributor

I think the exit on first success behavior in the line_stream.py function is incorrect or something. There are several paths that aren't getting picked up.

Needs tests.

@calebsmith calebsmith added the bug label Jul 11, 2014
@calebsmith
Copy link
Contributor Author

I think I've found the source of this bug, though my attempts at a quick fix aren't working. The logic around when a template gets added to the set of root node ids is wrong, and many root level templates that are not extended by anything are being excluded. However, simply adding them creates a lot of noise that also seems incorrect or at least wrongly grouped. In other words, we should likely group a collection of "top level" templates that belong to a given app and directory even if they are all independent.

@calebsmith
Copy link
Contributor Author

This no longer seems as crticial as we thought. All templates that extend or are extended are included. We can use a separate interface for other templates, maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant