Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor msgid, parameterize msgstr with agency-specific content #1187

Closed
2 tasks
thekaveman opened this issue Jan 9, 2023 · 0 comments · Fixed by #1196
Closed
2 tasks

Refactor msgid, parameterize msgstr with agency-specific content #1187

thekaveman opened this issue Jan 9, 2023 · 0 comments · Fixed by #1196
Assignees
Labels
back-end Django views, sessions, middleware, models, migrations etc. chore Chores and tasks for code cleanup, dev experience, admin/configuration settings, etc. i18n Copy: Language files or Django i18n framework

Comments

@thekaveman
Copy link
Member

A number of the msgstr in the current PO files are partially generic, but also partially reference a specific agency or agency's programs. For example, the success message after eligibility is verified via Login.gov:

msgid "enrollment.pages.index.mst_login.eligibility_confirmed_item.details"
msgstr ""
"Your eligibility has been verified by Login.gov. This benefit will give you "
"a half-price fare on public transportation with MST."

We want to be able to reuse the first part of this message across many agencies, and also to parameterize the second part to swap in the specific agency (and their discount if applicable).

Acceptance Criteria

  • Every msgstr that references a specific agency (or a specific agency's programs) directly, is either parameterized to accept the agency details or broken out into a minimal msgid/msgstr block
  • Every msgid corresponding to the above parameterized msgstrs is free from any specific agency identifier

Additional context

Corollary to #1186

@thekaveman thekaveman added chore Chores and tasks for code cleanup, dev experience, admin/configuration settings, etc. back-end Django views, sessions, middleware, models, migrations etc. i18n Copy: Language files or Django i18n framework labels Jan 9, 2023
@angela-tran angela-tran self-assigned this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. chore Chores and tasks for code cleanup, dev experience, admin/configuration settings, etc. i18n Copy: Language files or Django i18n framework
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants