Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAL-2198] Private git submodule inside monorepo causing error when we aren't careful to see what's in yarn.lock #10217

Open
hariombalhara opened this issue Jul 18, 2023 · 1 comment
Labels
🐛 bug Something isn't working ci area: CI, DX, pipeline, github actions ⬆️ dependencies Pull requests that update a dependency file Low priority Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync

Comments

@hariombalhara
Copy link
Member

hariombalhara commented Jul 18, 2023

This is how it happens

  • A contributor checkouts the code
  • He doesn't have access to auth, website, console
  • He runs yarn locally in three monorepo on his system that doesn't have the above folders and thus 3 package.json files are missing
  • Now, yarn ends up removing these 3 packages as well as their dependencies.
  • When a core contributor(who has access to the private repo) and that is checked out locally on his machine, runs yarn dev or any other yarn command, he would see an error like following. It basically says that there is apps/auth with package.json but that isn't there in yarn.lock

  • The only way to solve it is that he run yarn and commit the updated yarn.lock and solve it for others too.

I think that we should move auth, website, console outside the monorepo into their own repositories. These 3 being apps, aren't going to be a depenendency of each other and they are just going to need some packages from @calcom monorepo.

To allow an app like console, to be able to access to monorepo packages, we can maybe use file: URI in package.json to refer to local dependencies and use tsconfig compilerOptions path to map the packages to locally checked out monorepo
Screenshot 2023-07-18 at 3 41 21 PM

We can also go the ideal way where we publish all the packages in monorepo to npm and then use those packages.

From SyncLinear.com | CAL-2198

@hariombalhara hariombalhara changed the title Private git submodule inside monorepo causing error when we aren't careful to see what's in yarn.lock [CAL-2198] Private git submodule inside monorepo causing error when we aren't careful to see what's in yarn.lock Jul 18, 2023
@maige-app maige-app bot added 🐛 bug Something isn't working ⬆️ dependencies Pull requests that update a dependency file labels Jul 18, 2023
@PeerRich PeerRich added the Medium priority Created by Linear-GitHub Sync label Jul 18, 2023
@PeerRich PeerRich added the ci area: CI, DX, pipeline, github actions label Jul 19, 2023
@github-actions github-actions bot added the Stale label Sep 18, 2023
@hariombalhara hariombalhara added the Low priority Created by Linear-GitHub Sync label Nov 11, 2023
@zomars
Copy link
Member

zomars commented Mar 1, 2024

Added a new entry to our handbook hoping to clear things up. 🙏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ci area: CI, DX, pipeline, github actions ⬆️ dependencies Pull requests that update a dependency file Low priority Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

3 participants