Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing yarn.lock dependency tough-cookie #12497

Closed
krumware opened this issue Nov 22, 2023 · 2 comments
Closed

Missing yarn.lock dependency tough-cookie #12497

krumware opened this issue Nov 22, 2023 · 2 comments
Labels
🐛 bug Something isn't working ⬆️ dependencies Pull requests that update a dependency file Medium priority Created by Linear-GitHub Sync

Comments

@krumware
Copy link
Member

Found a bug? Please fill out the sections below. 👍

Issue Summary

This commit introduced jsdom to the dependencies. JSDOM has a dependency on @types/tough-cookie, but it doesn't appear it was successfully added to the yarn.lock
48dde24

Running yarn or yarn install again updates the yarn.lock file appropriately, but CICD processes which depend on the yarn.lock file will fail.

This is also breaking the cal.com/docker build.

(I believe the yarn.lock simply needs to be regenerated and updated)

Steps to Reproduce

  1. (for example) Went to ...
  2. Clicked on...
  3. ...

Any other relevant information. For example, why do you consider this a bug and what did you expect to happen instead?

Actual Results

  • Builds dependent on dependency lockfiles fail

Expected Results

  • Builds dependent on dependency lockfiles succeed

Technical details

n/a

Evidence

https://github.com/calcom/docker/actions/runs/6952718952/job/18932636904#step:10:295

@maige-app maige-app bot added ⬆️ dependencies Pull requests that update a dependency file 🐛 bug Something isn't working labels Nov 22, 2023
@krumware
Copy link
Member Author

I am also using node 18 as recommended.
I would make a PR for this but on my end there are many differences to the yarn.lock (mostly removals) and feel it may be most confidently addressed by a core team member.

@PeerRich PeerRich added the Medium priority Created by Linear-GitHub Sync label Nov 22, 2023
@hariombalhara
Copy link
Member

This is fixed in main now. I can see it
Screenshot 2023-11-23 at 12 20 50 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ⬆️ dependencies Pull requests that update a dependency file Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

3 participants