Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calls exodia.io/api/trending?page=1 #3207

Closed
TheCapsLock opened this issue Jun 30, 2022 · 5 comments · Fixed by #3323
Closed

Calls exodia.io/api/trending?page=1 #3207

TheCapsLock opened this issue Jun 30, 2022 · 5 comments · Fixed by #3323
Assignees
Labels
🐛 bug Something isn't working ✅ good first issue Good for newcomers 🙋🏻‍♂️help wanted Help from the community is appreciated
Milestone

Comments

@TheCapsLock
Copy link

TheCapsLock commented Jun 30, 2022

Found a bug? Please fill out the sections below. 👍

Issue Summary

Cal.com calls exodia.io and should not. OR it should be possible to disable it

In other words : we expect cal.com to be a schedule app not a NFT / crypto thing.

Steps to Reproduce

  1. Open network inspector
  2. Edit an event type
  3. 🍿

Technical details

  • Browser version, screen recording, console logs, network requests: You can make a recording with Bird Eats Bug.
  • Node.js version
  • Anything else that you think could be an issue.
@TheCapsLock
Copy link
Author

TheCapsLock commented Jun 30, 2022

Root cause is here

const exodiaList = await (await fetch(`https://exodia.io/api/trending?page=1`)).json();

Introduced by #1603

it would require changing CSP rule to allow something that is unwanted (exodia or any nft truc)

@agustif
Copy link
Contributor

agustif commented Jul 2, 2022

Hello @TheCapsLock, First of all, thank you for bringing this up.

I'll try to explain a bit, as I have some context of when I looked into upgrading our web3 code .
this code is part of our web3/metamask app, sadly this app was shipped just before we moved the codebase to the new monorepo (meaning code is actually really interwinded with whole webapp, and not separated from it), and also before the new -app store- for time, which makes each new app have it's own code separated/not executed if possible if the app is not enabled in the instance. (Which in cal.com is, as a user you can enable it or not for yourself)

Anyways, we had planned on moving the web3 app to rainbowkit/wagmi, and a user even approached me recently about working on that in our Slack, but as it stands it currently has some inter-winded code.

As an easy -hotfix- we could just make the call conditional on having web3/metamask enabled or not in your cal.com profile settings. In the future we will discard this altogether probably and implement it differently.

@TheCapsLock
Copy link
Author

Hi @agustif Thanks a lot for your feedback which gives more details about the situation. I'm very excited about the roadmap to handle this issue - thank you

@PeerRich
Copy link
Member

oh i was unaware it sends a request. yeah lets conditionally render it @agustif

@PeerRich PeerRich added the 🐛 bug Something isn't working label Jul 10, 2022
@PeerRich PeerRich added this to the v.1.8 milestone Jul 10, 2022
@PeerRich PeerRich assigned agustif and unassigned agustif Jul 10, 2022
@PeerRich PeerRich added ✅ good first issue Good for newcomers 🙋🏻‍♂️help wanted Help from the community is appreciated labels Jul 11, 2022
@joeauyeung joeauyeung self-assigned this Jul 13, 2022
@PeerRich
Copy link
Member

@TheCapsLock the entire call was removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ✅ good first issue Good for newcomers 🙋🏻‍♂️help wanted Help from the community is appreciated
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants