Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Connect Calendar #3582

Closed
shirazdole opened this issue Jul 28, 2022 · 13 comments · Fixed by #3891
Closed

Auto-Connect Calendar #3582

shirazdole opened this issue Jul 28, 2022 · 13 comments · Fixed by #3891
Assignees
Labels
✨ feature New feature or request 🧹 Improvements Improvements to existing features. Mostly UX/UI 🎨 needs design Before engineering kick-off, a designer needs to submit a mockup
Milestone

Comments

@shirazdole
Copy link
Member

shirazdole commented Jul 28, 2022

Is your proposal related to a problem?

When a calendar is disconnected, users are sent an email for them to reconnect their calendar.
65bc-356b-3153-03fbf301b653

Users then have to navigate to their cal account, to their integrations, and then reconnect the calendar. They also then have to reconnect each calendar that calendar was connected to - to the event types in advance settings.

Describe the solution you'd like

What we can do is a “Reconnect button” that takes you to the auth flow again instead of “Disconnect” and then “Connect” again. This should also automatically reconnect the calendars that were connected to the event types previously (currently when we have to disconnect and reconnect a calendar, that calendar gets removed from all event types it was connected to.)

It would be great to also have a flag notification next to event types that do not have a calendar connected to them. It's hard to know if a calendar is actually connected or not unless you navigate to the advance settings. This feels pretty important as well.

I believe that if there's no calendar, then it automatically picks the "default calendar" - the default calendar should be listed in the advanced setting anyways as it's not as intuitive.

@shirazdole shirazdole added ✨ feature New feature or request 🚨 urgent 🎨 needs design Before engineering kick-off, a designer needs to submit a mockup 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Jul 28, 2022
@shirazdole
Copy link
Member Author

cc @Jaibles thoughts on this portion: "It would be great to also have a flag notification next to event types that do not have a calendar connected to them. It's hard to know if a calendar is actually connected or not unless you navigate to the advance settings. This feels pretty important as well."

@shirazdole shirazdole added this to the v.1.9 milestone Jul 28, 2022
@PeerRich
Copy link
Member

cc @Jaibles thoughts on this portion: "It would be great to also have a flag notification next to event types that do not have a calendar connected to them. It's hard to know if a calendar is actually connected or not unless you navigate to the advance settings. This feels pretty important as well."

in general when an event-type has an issue. we could have a red flag / warning icon with a tool tip that says whats wrong

@dezerb
Copy link

dezerb commented Aug 1, 2022

@shirazdole @PeerRich I created small proposal how could like such a warning icon for this case
#3627

image

@leog
Copy link
Contributor

leog commented Aug 1, 2022

@shirazdole @PeerRich I created small proposal how could like such a warning icon for this case #3627

image

We already have a way to communicate extra information about the state of an event type. Maybe we can reuse it:
image

Something like:
image

@dezerb
Copy link

dezerb commented Aug 1, 2022

@leog such a solution is even less complicated, I pushed update to PR (with both solutions)

image

@shirazdole
Copy link
Member Author

@dezerb this looks great! cc @Jaibles

@ciaranha
Copy link
Member

ciaranha commented Aug 2, 2022

@dezerb great work 👏 can we add an icon to it?
CleanShot 2022-08-02 at 18 58 52@2x

@ciaranha
Copy link
Member

ciaranha commented Aug 2, 2022

They also then have to reconnect each calendar that calendar was connected to - to the event types in advance settings.

So I assume this is just for calendars for which the default calendar was overriden right? The other will be automatically reconnected when you reconnect?

@shirazdole
Copy link
Member Author

Correct, so if cal.com/shiraz/15min had shirazdole@gmail.com connected ( but that had to be disconnected and reconnected) then yes that should automatically get appended back to that event type rather than leave it blank (as it is now)
but say cal.com/shiraz/30min had shiraz@cal.com - that would just stay as is and not need to be touched

Did that answer your question?

@hariombalhara
Copy link
Member

Probably I am missing something.

I just tested the behaviour when no calendar is selected in the event type. The booking is still created according to this configuration in App.
Screenshot 2022-08-03 at 10 26 11 AM

So, it seems that the calendar is always there to create events on, it is just not explicitly specified in event type.

Now, if that calendar connection is actually working or not is a separate problem

@shirazdole
Copy link
Member Author

So, it seems that the calendar is always there to create events on, it is just not explicitly specified in event type.

Ooooh I didn't know this, that's a great point if that is the case. I think for consistency and clearness, it should be shown in the event type as is as well, but good to know the events will still be created!

@PeerRich
Copy link
Member

PeerRich commented Aug 4, 2022

in that case, best would be to just show the default there? the one that is set in calendar settings. so the "create event on" is not empty, but just shows the default calendar

@shirazdole
Copy link
Member Author

shirazdole commented Aug 4, 2022 via email

@ciaranha ciaranha modified the milestones: v.1.9, retro: v.1.9, v.2.0 Aug 16, 2022
@alannnc alannnc self-assigned this Aug 16, 2022
@alannnc alannnc linked a pull request Aug 17, 2022 that will close this issue
3 tasks
@kodiakhq kodiakhq bot closed this as completed in #3891 Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature New feature or request 🧹 Improvements Improvements to existing features. Mostly UX/UI 🎨 needs design Before engineering kick-off, a designer needs to submit a mockup
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants