Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/settings/appearance - change the theme options to a 3 option fancy radio with image #4232

Closed
ciaranha opened this issue Sep 7, 2022 · 4 comments · Fixed by #4371
Closed

/settings/appearance - change the theme options to a 3 option fancy radio with image #4232

ciaranha opened this issue Sep 7, 2022 · 4 comments · Fixed by #4371
Labels
⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work
Milestone
v2.0

Comments

@ciaranha
Copy link
Member

ciaranha commented Sep 7, 2022 •
edited

Image

View in Figma

SVGS ready.. with grainy effect in SVG!!

Image
Image
Image
@ciaranha ciaranha added this to the Quick Wins milestone Sep 7, 2022
@PeerRich PeerRich added the ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work label Sep 7, 2022
@PeerRich PeerRich modified the milestones: Quick Wins, v.2.0 Sep 7, 2022
@noahflk
Copy link
Contributor

noahflk commented Sep 7, 2022

I'd like to take this on

@emrysal
Copy link
Contributor

emrysal commented Sep 8, 2022

Hi @noahflk we're more than happy for you to do so; have a look @ https://flowbite.com/docs/forms/radio/#advanced-layout for how we thought it could be implemented.

@PeerRich
Copy link
Member

PeerRich commented Sep 8, 2022

Hi @noahflk we're more than happy for you to do so; have a look @ https://flowbite.com/docs/forms/radio/#advanced-layout for how we thought it could be implemented.

with radix UI tho

@emrysal
Copy link
Contributor

emrysal commented Sep 8, 2022

@PeerRich Not in this case IMO, Radix UI has nothing built-in that works for this without overheads. ToggleGroup can do it but brings with it a lot of state where we do not need state. Using native we prevent unnecessary re-renders.

@JeroenReumkens JeroenReumkens mentioned this issue Sep 11, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work
Projects
No open projects
Cal.com Core Roadmap
Status: Done
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

feat: 4232 - new theme toggle design. JeroenReumkens/cal.com
4 participants
@emrysal @ciaranha @PeerRich @noahflk