Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAL-863] No available users found error on confirming booking for an open slot #6622

Closed
ChipWolf opened this issue Jan 22, 2023 · 64 comments · Fixed by #7462
Closed

[CAL-863] No available users found error on confirming booking for an open slot #6622

ChipWolf opened this issue Jan 22, 2023 · 64 comments · Fixed by #7462
Assignees
Labels
💎 Bounty A bounty on Algora.io 🐛 bug Something isn't working linear Sync Github Issue from community members to Linear.app 💰 Rewarded Rewarded bounties on Algora.io Urgent Created by Linear-GitHub Sync 🚧 wip / in the making This is currently being worked on
Milestone

Comments

@ChipWolf
Copy link

ChipWolf commented Jan 22, 2023

Found a bug? Please fill out the sections below. 👍

Issue Summary

I have not replicated this personally, but I have had different users report this error on more than occasion.

When confirming an individual booking [not a team page], some users have seen this error: "Could not book the meeting. No available users found."

image

CAL-863

@PeerRich
Copy link
Member

by any chance, is your event-type link called "book"? thats an ongoing issue we are fixing right now

@ChipWolf
Copy link
Author

by any chance, is your event-type link called "book"? thats an ongoing issue we are fixing right now

It isn't, it's called bau

@PeerRich
Copy link
Member

weird...

we're putting in a lot of work right now in the booking page, maybe a team member knows more. you said you cant reproduce this. any idea what this could cause?

@PeerRich PeerRich added 🐛 bug Something isn't working 👩‍🔬 needs investigation linear Sync Github Issue from community members to Linear.app labels Jan 22, 2023
@PeerRich PeerRich changed the title No available users found error on confirming booking for an open slot [CAL-863] No available users found error on confirming booking for an open slot Jan 22, 2023
@stephane-klein
Copy link

Same error for me, with 2 different contacts (without account in cal.com).

@PeerRich PeerRich added the High priority Created by Linear-GitHub Sync label Jan 26, 2023
@PeerRich
Copy link
Member

upgraded to urgent. we need to get rid of this error message all-together and get to the bottom of this

@PeerRich PeerRich added Urgent Created by Linear-GitHub Sync and removed High priority Created by Linear-GitHub Sync labels Jan 26, 2023
@PeerRich PeerRich added this to the 2.6 milestone Jan 26, 2023
@milospuac
Copy link
Contributor

@ChipWolf Is this slot made available through a date override?

@stephane-klein
Copy link

date override?

@milospuac yes for me 👍

@chadamski
Copy link

This is also impacting users trying to book through my cal.com link. The slots are not available through date overrides, just normal, open slots.

@stephane-klein
Copy link

I think that the "No available users found." error message come from this line.

@stephane-klein
Copy link

Why this line

const { busy: bufferedBusyTimes, workingHours } = await getUserAvailability(

don't get dateOverrides variable? 🤔

@PeerRich
Copy link
Member

@emrysal

@ChipWolf
Copy link
Author

@ChipWolf Is this slot made available through a date override?

Yes

@stephane-klein
Copy link

@ChipWolf @PeerRich Question: do you have a Merge Request in work in progres to share about this is issue ?

@PeerRich
Copy link
Member

PeerRich commented Feb 1, 2023

not yet, i believe different issues cause the same (bad) error message of "No available users found"

@stephane-klein
Copy link

Some news about this issue?

I'm stuck, waiting for this bug to be fixed and I don't know if it's better if I try to fix this bug myself or if I should go to https://calendly.com/ or https://savvycal.com 🤔

@PeerRich
Copy link
Member

PeerRich commented Feb 5, 2023

hey, we are actively working on this, it seems to be some sort of user error because it doenst show up for each user.

I understand this is super annoying which is why it has an urgent flag

@PeerRich PeerRich added the 🚧 wip / in the making This is currently being worked on label Feb 5, 2023
@PeerRich
Copy link
Member

PeerRich commented Feb 5, 2023

lemme also give it a bounty

/bounty 1000

@algora-pbc
Copy link

algora-pbc bot commented Feb 5, 2023

💎 $1,000.00 bounty created by PeerRich
👉 To claim this bounty, submit a pull request that includes the text /claim #6622 somewhere in its body
📝 To receive payouts, join Algora and complete the relevant onboarding steps
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
🙏 Thank you for contributing to calcom/cal.com!

@algora-pbc algora-pbc bot added the 💎 Bounty A bounty on Algora.io label Feb 5, 2023
@PeerRich
Copy link
Member

PeerRich commented Feb 5, 2023

@stephane-klein I cannot reproduce this on your link

CleanShot 2023-02-05 at 10 42 03@2x

@wamoyo
Copy link

wamoyo commented Mar 3, 2023

Same issue for me.

URL: https://cal.com/innovationbound/book?type=211681&month=2023-04&date=2023-04-03T09%3A00%3A00-04%3A00&slug=45-min-meeting&count=

Screenshot from 2023-03-02 21-29-42

Had to have a potential client tell me : (
Not good : (

@elmerohueso
Copy link

@zomars When should this fix go live on the website, so I can tell my users/clients?

@zomars
Copy link
Member

zomars commented Mar 3, 2023

@elmerohueso Monday we will tag a release

@elmerohueso
Copy link

Great!

@PeerRich PeerRich reopened this Mar 7, 2023
@algora-pbc
Copy link

algora-pbc bot commented Mar 7, 2023

@roae cal wants to reward your solution. Please sign up on Algora, link your Github account and connect with Stripe on your dashboard.

@ShaneMaglangit
Copy link
Contributor

ShaneMaglangit commented Mar 7, 2023

Glad that this is getting resolve.

I would suggest that we re-evaluate having Dayjs as the dependency. It has been getting a lot of complaints due to how buggy it is when dealing with timezones (due to daylight savings) and how unresponsive the maintainer is. Last commit was 3 weeks ago. Tons of projects already moved away from it.

Its practically unmaintained: https://github.com/iamkun/dayjs/pulse/monthly

@algora-pbc
Copy link

algora-pbc bot commented Mar 7, 2023

roae has completed their onboarding. You can now complete the payment on your org dashboard

@elmerohueso
Copy link

elmerohueso commented Mar 8, 2023

@roae It looks likes the problem still exists for March 12th (DST starts at 2AM, local time, on March 12th). It does, however, appear to be working after that.

@PeerRich
Copy link
Member

PeerRich commented Mar 8, 2023

@ShaneMaglangit whats a good alternative?

@emrysal you experience a lot of issues with dayjs. is it time switching?

@ShaneMaglangit
Copy link
Contributor

@ShaneMaglangit whats a good alternative?

@emrysal you experience a lot of issues with dayjs. is it time switching?

I have been seeing positive comments about Luxon, which is maintained by the people behind Moment.js. I believe that its something worth considering as an alternative.

@emrysal
Copy link
Contributor

emrysal commented Mar 8, 2023

The primary issue with dayjs is the ease in which you can make errors:

E.g. dayjs("2023-01-02T22:00:00Z").utc() is NOT the same as dayjs.utc("2023-01-02T22:00:00Z") - in this example the resulting time can be miles off, both will be in UTC mode but one is adjusted to the local time and the other is not.

Every dayjs line has to be carefully considered and taking into account the three timezones we are dealing with - organizer, system and booker time.

@tomml
Copy link

tomml commented Mar 10, 2023

I am facing the same error message, but maybe a different scenario here.
See my bookings: https://cal.com/mobile-massage-rgb/25
There, the appointment for 3:55pm (timezone is europe/amsterdam as I am from germany) should be bookable, but if I understand correctly it does not fit my availability. The availability time slot can only be set by 15min slots. Mine is set to 1pm till 4:15pm. The appointment time by the other hand can be an exact 1min slot. 25minutes in my case. I tried to make my availability till 4:30pm, but then there appears another appointment starting at 4:20pm, which also does not fit the availability schedule.
With this time settings always the last appointment slot is not bookable by my clients facing the error message OP posted.
How to resolve that issue?

@ShaneMaglangit
Copy link
Contributor

ShaneMaglangit commented Mar 10, 2023

I am facing the same error message, but maybe a different scenario here. See my bookings: https://cal.com/mobile-massage-rgb/25 There, the appointment for 3:55pm (timezone is europe/amsterdam as I am from germany) should be bookable, but if I understand correctly it does not fit my availability. The availability time slot can only be set by 15min slots. Mine is set to 1pm till 4:15pm. The appointment time by the other hand can be an exact 1min slot. 25minutes in my case. I tried to make my availability till 4:30pm, but then there appears another appointment starting at 4:20pm, which also does not fit the availability schedule. With this time settings always the last appointment slot is not bookable by my clients facing the error message OP posted. How to resolve that issue?

Yup, this is a slightly different issue. I can create a quick PR to fix this as I have already identified where this bug is found before. Just have to check if there any existing PR for this.

Edit: Seems to be a known issue assigned to a member of team #7167

@algora-pbc
Copy link

algora-pbc bot commented Mar 15, 2023

🎉🎈 @roae has been awarded $1,000! 🎈🎊

@algora-pbc algora-pbc bot added the 💰 Rewarded Rewarded bounties on Algora.io label Mar 15, 2023
@PeerRich
Copy link
Member

we ended up hiring @roae ❤️

@PeerRich PeerRich reopened this Mar 15, 2023
@roae
Copy link
Contributor

roae commented Mar 18, 2023

Fixed on #7792

@roae roae closed this as completed Mar 18, 2023
@PeerRich PeerRich modified the milestones: v.2.8, 2.7 Mar 19, 2023
@ShaneMaglangit
Copy link
Contributor

ShaneMaglangit commented Apr 25, 2023

@PeerRich still randomly encountering this error btw, atleast with a better error message now.

@PeerRich
Copy link
Member

yeah the amount has really decreased. we're investigating the last couple times

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 Bounty A bounty on Algora.io 🐛 bug Something isn't working linear Sync Github Issue from community members to Linear.app 💰 Rewarded Rewarded bounties on Algora.io Urgent Created by Linear-GitHub Sync 🚧 wip / in the making This is currently being worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.